Add new strings for Release notes notification title and message, and

suggestion chip for Help app.

Bug: b/169897551, b/175501984
Change-Id: I841c438a40c5399df062ce95dfcf375ee1fd587f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592227Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Callistus Tan <callistus@google.com>
Cr-Commit-Position: refs/heads/master@{#837326}

chrome/app/chromeos_strings.grdp

@@ -5707,11 +5707,12 @@
     The next time you restart your device, your administrator will perform a one-time update that will delete your local data.
   </message>
 
-  <message name="IDS_RELEASE_NOTES_DEVICE_SPECIFIC_NOTIFICATION_TITLE" desc="Text for the notification title informing the user that the device has been updated and patch notes are available. Will specify the user's Chrome OS device.">
+  <!-- Strings for Release Notes notification -->
+  <message name="IDS_RELEASE_NOTES_DEVICE_SPECIFIC_NOTIFICATION_TITLE" desc="Text for the notification title informing the user that the device has been updated and patch notes are available. Will specify the user's Chrome OS device. [CHAR_LIMIT=40]">
     See what's new on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
   </message>
   <message name="IDS_RELEASE_NOTES_NOTIFICATION_MESSAGE" desc="Text for the notification message informing the user that the device has been updated and patch notes are available.">
-    Get highlights from the latest update
+    Work better across devices, do things faster, and more
   </message>
 
   <!-- Strings for EDU Coexistence flow -->

chrome/app/chromeos_strings_grdp/IDS_RELEASE_NOTES_NOTIFICATION_MESSAGE.png.sha1

-51e6a2ba245da0527c4d1a77142448a6f9d42f35
\ No newline at end of file
+50fd95a19c01bb17f5272767d6aed6a4b1818072
\ No newline at end of file

chrome/browser/chromeos/release_notes/release_notes_notification_unittest.cc

@@ -5,6 +5,7 @@
 #include "chrome/browser/chromeos/release_notes/release_notes_notification.h"
 
 #include "base/feature_list.h"
+#include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/version.h"
 #include "chrome/browser/notifications/notification_display_service_tester.h"
@@ -96,6 +97,8 @@ TEST_F(ReleaseNotesNotificationTest, ShowReleaseNotesNotification) {
   EXPECT_EQ(ui::SubstituteChromeOSDeviceType(
                 IDS_RELEASE_NOTES_DEVICE_SPECIFIC_NOTIFICATION_TITLE),
             GetReleaseNotesNotification().title());
+  EXPECT_EQ("Work better across devices, do things faster, and more",
+            base::UTF16ToASCII(GetReleaseNotesNotification().message()));
   EXPECT_EQ(1, notification_count_);
 }
 

chrome/browser/ui/app_list/search/app_list_search_browsertest.cc

@@ -142,9 +142,7 @@ IN_PROC_BROWSER_TEST_F(AppListSearchBrowserTest,
 
   auto* result = FindResult("help-app://updates");
   ASSERT_TRUE(result);
-  // Has Release notes title.
-  EXPECT_EQ(base::UTF16ToASCII(result->title()),
-            "See what's new on your Chrome device");
+  EXPECT_EQ(base::UTF16ToASCII(result->title()), "What's new with Chrome OS");
   // Displayed in first position.
   EXPECT_EQ(result->position_priority(), 1.0f);
   EXPECT_EQ(result->display_type(), DisplayType::kChip);

chrome/browser/ui/app_list/search/help_app_provider.cc

@@ -17,7 +17,8 @@
 #include "chrome/browser/web_applications/components/web_app_id_constants.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/grit/generated_resources.h"
-#include "ui/chromeos/devicetype_utils.h"
+#include "chromeos/strings/grit/chromeos_strings.h"
+#include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
@@ -34,8 +35,7 @@ HelpAppResult::HelpAppResult(float relevance,
     : profile_(profile) {
   DCHECK(profile_);
   set_id(kHelpAppResult);
-  SetTitle(ui::SubstituteChromeOSDeviceType(
-      IDS_RELEASE_NOTES_DEVICE_SPECIFIC_NOTIFICATION_TITLE));
+  SetTitle(l10n_util::GetStringUTF16(IDS_HELP_APP_WHATS_NEW_SUGGESTION_CHIP));
   // Show this in the first position, in front of any other chips that may be
   // also claiming the first slot.
   SetDisplayIndex(DisplayIndex::kFirstIndex);

chromeos/chromeos_strings.grd

@@ -299,6 +299,9 @@ Try tapping the mic to ask me anything.
       <message name="IDS_HELP_APP_PERKS" desc="Name of a tab in the Help app that offers users additional perks like apps or drive storage space.">
         Perks
       </message>
+      <message name="IDS_HELP_APP_WHATS_NEW_SUGGESTION_CHIP" desc="Text for the suggestion chip to view updated patch notes are available. [CHAR_LIMIT=24]">
+        What's new with Chrome OS
+      </message>
 
       <!-- Media App -->
       <message name="IDS_MEDIA_APP_APP_NAME" desc="Name of the Media App in the app shelf. This app is the default installed app to open and edit images, video, pdf and audio files." meaning="App name.">

chromeos/chromeos_strings_grd/IDS_HELP_APP_WHATS_NEW_SUGGESTION_CHIP.png.sha1

+141380e3fbf93f89b1f4b44dd9b2053869625447
\ No newline at end of file