screen orientation: Use ScriptPromise::RejectWithDOMException().

No functional changes; simplify the code by using the function above rather
than manually creating a ScriptPromiseResolver, a ScriptPromise and then
passing a DOMException to the ScriptPromise.

Change-Id: I65a266dfd95f7d03b5b06cd6ca4fdd85aff67df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878069
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710033}

third_party/blink/renderer/modules/screen_orientation/screen_orientation.cc

@@ -149,28 +149,25 @@ void ScreenOrientation::SetAngle(uint16_t angle) {
 
 ScriptPromise ScreenOrientation::lock(ScriptState* state,
                                       const AtomicString& lock_string) {
-  auto* resolver = MakeGarbageCollected<ScriptPromiseResolver>(state);
-  ScriptPromise promise = resolver->Promise();
-
   Document* document = GetFrame() ? GetFrame()->GetDocument() : nullptr;
 
   if (!document || !Controller()) {
-    auto* exception = MakeGarbageCollected<DOMException>(
-        DOMExceptionCode::kInvalidStateError,
-        "The object is no longer associated to a document.");
-    resolver->Reject(exception);
-    return promise;
+    return ScriptPromise::RejectWithDOMException(
+        state, MakeGarbageCollected<DOMException>(
+                   DOMExceptionCode::kInvalidStateError,
+                   "The object is no longer associated to a document."));
   }
 
   if (document->IsSandboxed(WebSandboxFlags::kOrientationLock)) {
-    auto* exception = MakeGarbageCollected<DOMException>(
-        DOMExceptionCode::kSecurityError,
-        "The document is sandboxed and lacks the "
-        "'allow-orientation-lock' flag.");
-    resolver->Reject(exception);
-    return promise;
+    return ScriptPromise::RejectWithDOMException(
+        state, MakeGarbageCollected<DOMException>(
+                   DOMExceptionCode::kSecurityError,
+                   "The document is sandboxed and lacks the "
+                   "'allow-orientation-lock' flag."));
   }
 
+  auto* resolver = MakeGarbageCollected<ScriptPromiseResolver>(state);
+  ScriptPromise promise = resolver->Promise();
   Controller()->lock(StringToOrientationLock(lock_string),
                      std::make_unique<LockOrientationCallback>(resolver));
   return promise;