Commit 24ae0f10 authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

Disable LogMessageMarkerOnStack on Windows

The newly added test LoggingTest.LogMessageMarkersOnStack caused
consistent crash on Win10 Test. Disable it ATM and TBR the owner.

TBR=wez@chromium.org
NOTRY=true

Bug: 897735
Change-Id: Ic775ac5a5cccbe6c5064407ac17534018561468b
Reviewed-on: https://chromium-review.googlesource.com/c/1293670Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601567}
parent 2009e012
...@@ -829,10 +829,17 @@ TEST_F(LoggingTest, LogPrefix) { ...@@ -829,10 +829,17 @@ TEST_F(LoggingTest, LogPrefix) {
log_string_ptr = nullptr; log_string_ptr = nullptr;
} }
// Crashes on Win 10 only. https://crbug.com/897735
#if defined(OS_WIN)
#define MAYBE_LogMessageMarkersOnStack DISABLED_LogMessageMarkersOnStack
#else
#define MAYBE_LogMessageMarkersOnStack LogMessageMarkersOnStack
#endif
#if !defined(ADDRESS_SANITIZER) && !defined(MEMORY_SANITIZER) #if !defined(ADDRESS_SANITIZER) && !defined(MEMORY_SANITIZER)
// Since we scan potentially uninitialized portions of the stack, we can't run // Since we scan potentially uninitialized portions of the stack, we can't run
// this test under any sanitizer that checks for uninitialized reads. // this test under any sanitizer that checks for uninitialized reads.
TEST_F(LoggingTest, LogMessageMarkersOnStack) { TEST_F(LoggingTest, MAYBE_LogMessageMarkersOnStack) {
const uint32_t kLogStartMarker = 0xbedead01; const uint32_t kLogStartMarker = 0xbedead01;
const uint32_t kLogEndMarker = 0x5050dead; const uint32_t kLogEndMarker = 0x5050dead;
const char kTestMessage[] = "Oh noes! I have crashed! 💩"; const char kTestMessage[] = "Oh noes! I have crashed! 💩";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment