Deflake background-blend-mode-gif-color-2.html

The test is attempting to catch the second frame of an animated GIF (2 x 400ms frames) using setTimeout(400). This is super-fragile. Refactor to use advanceImageAnimation() intead. BUG=chromium:734733,chromium:729075 Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef Reviewed-on: https://chromium-review.googlesource.com/541037Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#481075}

Deflake background-blend-mode-gif-color-2.html
The test is attempting to catch the second frame of an animated GIF (2 x 400ms frames) using setTimeout(400). This is super-fragile. Refactor to use advanceImageAnimation() intead. BUG=chromium:734733,chromium:729075 Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef Reviewed-on: https://chromium-review.googlesource.com/541037Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#481075}
24c9f587 · Florin Malita · Commit Bot · 5651a37f · 24c9f587 · 5651a37f
Commit 24c9f587 authored Jun 20, 2017 by Florin Malita Committed by Commit Bot Jun 21, 2017
3 changed files
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1281,8 +1281,6 @@ crbug.com/658305 css3/filters/effect-reference-zoom.html [ Failure Pass ]
 crbug.com/658305 css3/filters/effect-reference-zoom-hw.html [ Failure Pass ]
 crbug.com/658305 css3/filters/filter-effect-removed.html [ Failure Pass ]

-crbug.com/734733 css3/blending/background-blend-mode-gif-color-2.html [ Failure Pass ]
-
 crbug.com/267206 [ Mac ] fast/scrolling/scrollbar-tickmarks-hittest.html [ Timeout ]
 crbug.com/267206 [ Mac ] virtual/scroll_customization/fast/scrolling/scrollbar-tickmarks-hittest.html [ Timeout ]


--- a/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2-expected.png
+++ b/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2-expected.png
--- a/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2.html
+++ b/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2.html
@@ -10,16 +10,7 @@
        margin: 5px;
    }
 </style>
-<script type="text/javascript">
-    if (window.testRunner)
-        window.testRunner.waitUntilDone();

-    function done() {
-        if (window.testRunner)
-            window.testRunner.notifyDone();
-    }
-
-</script>
 </head>
 <!-- This file should contain a gif on top of a background color with every type of blending. -->
 <body>
@@ -38,8 +29,23 @@
    <div style="background-blend-mode: saturation, normal"></div>
    <div style="background-blend-mode: color, normal"></div>
    <div style="background-blend-mode: luminosity, normal"></div>
+
+    <img id='image' style='display: none'>
+
    <script type="text/javascript">
-        window.setTimeout("done()", 400);
+      onload = function() {
+        if (window.testRunner)
+          testRunner.waitUntilDone();
+
+        // use a parallel instance to drive the animation
+        image.src = 'resources/squares.gif';
+        image.onload = function() {
+          if (window.testRunner) {
+            internals.advanceImageAnimation(image);
+            testRunner.notifyDone();
+          }
+        };
+      };
    </script>
 </body>
 </html>