[CrOS Network] Fix <network-config> spinner.
Spinner functionality in <network-config> broke due to a refactor [1] which started using a template with if="[[!managedProperties_]]". However, managedProperties_ starts out as undefined, and Polymer does not evaluate if's whose properties are all undefined [2]. Since, in this case, the managedProperties_ property is the only one used, all of the properties are undefined, and the template was never evaluated until the properties were received and the spinner was no longer needed. This CL fixes the issue by explicitly using null instead of undefined in this case. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1803724 [2] https://polymer-library.polymer-project.org/2.0/docs/devguide/observers#observers-and-element-initialization Fixed: 1014057 Change-Id: I1f8775fc3136387508959f1fc914aa564434fac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879752Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#709204}
Showing
Please register or sign in to comment