Commit 2503eb6f authored by Matt Menke's avatar Matt Menke Committed by Commit Bot

Disable TCPSocketTest.DestroyWithPendingWrite on Fuchsia.

close(socket_fd_) is sometimes hanging in this test. While that doesn't
necessarily mean this is a Fuchsia bug, it seems likely, given that this
test passes on all other platforms, and the underlying code hasn't
changed since this test was enabled on Fuchsia.

Bug: 1005042
Change-Id: I71babfc0472658b662a3c9232f05ad4abe5b1e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825323
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699966}
parent e0c72d9c
...@@ -604,7 +604,14 @@ TEST_F(TCPClientSocketTest, SuspendDuringRead) { ...@@ -604,7 +604,14 @@ TEST_F(TCPClientSocketTest, SuspendDuringRead) {
IsError(ERR_NETWORK_IO_SUSPENDED)); IsError(ERR_NETWORK_IO_SUSPENDED));
} }
TEST_F(TCPClientSocketTest, SuspendDuringWrite) { // TODO(https://crbug.com/1005042): close(socket_fd_) hangs on Fuchsia in this
// test.
#if defined(OS_FUCHSIA)
#define MAYBE_SuspendDuringWrite DISABLED_SuspendDuringWrite
#else
#define MAYBE_SuspendDuringWrite SuspendDuringWrite
#endif
TEST_F(TCPClientSocketTest, MAYBE_SuspendDuringWrite) {
std::unique_ptr<StreamSocket> accepted_socket; std::unique_ptr<StreamSocket> accepted_socket;
std::unique_ptr<TCPClientSocket> client_socket; std::unique_ptr<TCPClientSocket> client_socket;
CreateConnectedSockets(&accepted_socket, &client_socket); CreateConnectedSockets(&accepted_socket, &client_socket);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment