Commit 2519890e authored by tommi@chromium.org's avatar tommi@chromium.org

Call GetDefaultOutputDeviceID() from GetDefaultOutputStreamParameters()...

Call GetDefaultOutputDeviceID() from GetDefaultOutputStreamParameters() instead of specifying an empty string.

BUG=285437
R=henrika@chromium.org

Review URL: https://codereview.chromium.org/23440020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221429 0039d316-1c4b-4281-b951-d872f2087c98
parent 5f4dc4f8
...@@ -400,7 +400,8 @@ void AudioManagerBase::NotifyAllOutputDeviceChangeListeners() { ...@@ -400,7 +400,8 @@ void AudioManagerBase::NotifyAllOutputDeviceChangeListeners() {
} }
AudioParameters AudioManagerBase::GetDefaultOutputStreamParameters() { AudioParameters AudioManagerBase::GetDefaultOutputStreamParameters() {
return GetPreferredOutputStreamParameters("", AudioParameters()); return GetPreferredOutputStreamParameters(GetDefaultOutputDeviceID(),
AudioParameters());
} }
AudioParameters AudioManagerBase::GetOutputStreamParameters( AudioParameters AudioManagerBase::GetOutputStreamParameters(
......
...@@ -365,9 +365,6 @@ std::string AudioManagerWin::GetDefaultOutputDeviceID() { ...@@ -365,9 +365,6 @@ std::string AudioManagerWin::GetDefaultOutputDeviceID() {
AudioParameters AudioManagerWin::GetPreferredOutputStreamParameters( AudioParameters AudioManagerWin::GetPreferredOutputStreamParameters(
const std::string& output_device_id, const std::string& output_device_id,
const AudioParameters& input_params) { const AudioParameters& input_params) {
// TODO(tommi): Support |output_device_id|.
DLOG_IF(ERROR, !output_device_id.empty()) << "Not implemented!";
const bool core_audio_supported = CoreAudioUtil::IsSupported(); const bool core_audio_supported = CoreAudioUtil::IsSupported();
DLOG_IF(ERROR, !core_audio_supported && !output_device_id.empty()) DLOG_IF(ERROR, !core_audio_supported && !output_device_id.empty())
<< "CoreAudio is required to open non-default devices."; << "CoreAudio is required to open non-default devices.";
...@@ -392,8 +389,10 @@ AudioParameters AudioManagerWin::GetPreferredOutputStreamParameters( ...@@ -392,8 +389,10 @@ AudioParameters AudioManagerWin::GetPreferredOutputStreamParameters(
channel_layout = input_params.channel_layout(); channel_layout = input_params.channel_layout();
} else { } else {
AudioParameters params; AudioParameters params;
HRESULT hr = CoreAudioUtil::GetPreferredAudioParameters(output_device_id, HRESULT hr = CoreAudioUtil::GetPreferredAudioParameters(
&params); output_device_id.empty() ?
GetDefaultOutputDeviceID() : output_device_id,
&params);
if (SUCCEEDED(hr)) { if (SUCCEEDED(hr)) {
bits_per_sample = params.bits_per_sample(); bits_per_sample = params.bits_per_sample();
buffer_size = params.frames_per_buffer(); buffer_size = params.frames_per_buffer();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment