Commit 25268993 authored by pfeldman@chromium.org's avatar pfeldman@chromium.org

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't use innerText, use textContent instead.
        https://bugs.webkit.org/show_bug.cgi?id=56307

        * inspector/elements/edit-dom-actions-expected.txt:
        * inspector/elements/edit-dom-actions.html:
        * inspector/extensions/extensions-audits-expected.txt:
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't use innerText, use textContent instead.
        https://bugs.webkit.org/show_bug.cgi?id=56307

        * inspector/front-end/AuditFormatters.js:
        (WebInspector.AuditFormatters.snippet):
        * inspector/front-end/ElementsTreeOutline.js:
        * inspector/front-end/GoToLineDialog.js:
        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen):
        * inspector/front-end/ShortcutsHelp.js:
        (WebInspector.ShortcutsSection.prototype.renderSection):
        (WebInspector.ShortcutsSection.prototype._renderHeader):

git-svn-id: svn://svn.chromium.org/blink/trunk@81023 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent a0191341
2011-03-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: don't use innerText, use textContent instead.
https://bugs.webkit.org/show_bug.cgi?id=56307
* inspector/elements/edit-dom-actions-expected.txt:
* inspector/elements/edit-dom-actions.html:
* inspector/extensions/extensions-audits-expected.txt:
2011-03-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
......@@ -34,6 +34,26 @@ Running: testSetNodeValue
<div id="node-to-set-value">Edited Text</div>
</div>
Running: testSetAttribute
==== before ====
- <div id="testSetAttribute">
<div foo="attribute value" id="node-to-set-attribute"></div>
</div>
==== after ====
- <div id="testSetAttribute">
<div id="node-to-set-attribute" bar="edited attribute"></div>
</div>
Running: testRemoveAttribute
==== before ====
- <div id="testRemoveAttribute">
<div foo="attribute value" id="node-to-remove-attribute"></div>
</div>
==== after ====
- <div id="testRemoveAttribute">
<div id="node-to-remove-attribute"></div>
</div>
Running: testAddAttribute
==== before ====
- <div id="testAddAttribute">
......
......@@ -47,7 +47,7 @@ function test()
editNodePartAndRun(node, "webkit-html-text-node", "Edited Text", done);
}
},
/*
function testSetAttribute(next)
{
domActionTest("testSetAttribute", "node-to-set-attribute", testBody, next);
......@@ -67,7 +67,7 @@ function test()
editNodePartAndRun(node, "webkit-html-attribute", "", done);
}
},
*/
function testAddAttribute(next)
{
domActionTest("testAddAttribute", "node-to-add-attribute", testBody, next);
......
......@@ -16,9 +16,9 @@ Added audit category.
http://www.google.com
... and a snippet
function rand()
{
return 4;
}
{
return 4;
}
Passed rule
this rule always passes ok
Extension audits that fail
......
2011-03-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: don't use innerText, use textContent instead.
https://bugs.webkit.org/show_bug.cgi?id=56307
* inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.snippet):
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/GoToLineDialog.js:
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen):
* inspector/front-end/ShortcutsHelp.js:
(WebInspector.ShortcutsSection.prototype.renderSection):
(WebInspector.ShortcutsSection.prototype._renderHeader):
2011-03-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
......
......@@ -66,7 +66,7 @@ WebInspector.AuditFormatters = {
snippet: function(snippetText)
{
var div = document.createElement("div");
div.innerText = snippetText;
div.textContent = snippetText;
div.className = "source-code";
return div;
},
......
......@@ -880,7 +880,7 @@ WebInspector.ElementsTreeElement.prototype = {
if (!attributeNameElement)
return false;
var attributeName = attributeNameElement.innerText;
var attributeName = attributeNameElement.textContent;
function removeZeroWidthSpaceRecursive(node)
{
......
......@@ -40,7 +40,7 @@ WebInspector.GoToLineDialog = function(view)
var dialogWindow = this._element;
dialogWindow.createChild("label").innerText = WebInspector.UIString("Go to line: ");
dialogWindow.createChild("label").textContent = WebInspector.UIString("Go to line: ");
this._input = dialogWindow.createChild("input");
this._input.setAttribute("type", "text");
......@@ -53,7 +53,7 @@ WebInspector.GoToLineDialog = function(view)
var go = dialogWindow.createChild("button");
go.innerText = WebInspector.UIString("Go");
go.textContent = WebInspector.UIString("Go");
go.addEventListener("click", this._onClick.bind(this), false);
go.addEventListener("mousedown", function(e) {
// Ok button click will close the dialog, removing onBlur listener
......
......@@ -40,9 +40,9 @@ WebInspector.HelpScreen = function(title)
this.contentElement = mainWindow.createChild("div", "help-content");
this.contentElement.tabIndex = 0;
this.contentElement.addEventListener("blur", this._onBlur.bind(this), false);
captionWindow.createChild("h1", "help-window-title").innerText = title;
captionWindow.createChild("h1", "help-window-title").textContent = title;
closeButton.innerText = "\u2716"; // Code stands for HEAVY MULTIPLICATION X.
closeButton.textContent = "\u2716"; // Code stands for HEAVY MULTIPLICATION X.
closeButton.addEventListener("click", this._hide.bind(this), false);
this._closeKeys = [
WebInspector.KeyboardShortcut.Keys.Enter.code,
......
......@@ -125,7 +125,7 @@ WebInspector.ShortcutsSection.prototype = {
for (var line = 0; line < this._lines.length; ++line) {
var tr = parent.createChild("tr");
tr.createChild("td", "help-key-cell").innerHTML = this._lines[line].key + " : ";
tr.createChild("td").innerText = this._lines[line].text;
tr.createChild("td").textContent = this._lines[line].text;
}
},
......@@ -134,7 +134,7 @@ WebInspector.ShortcutsSection.prototype = {
var trHead = parent.createChild("tr");
trHead.createChild("th");
trHead.createChild("th").innerText = this.name;
trHead.createChild("th").textContent = this.name;
},
_renderSequence: function(sequence, delimiter)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment