Work more on getting things built with -Wimplicit-fallthrough.

This CL was uploaded by git cl split.

R=alancutter@chromium.org

Bug: 177475
Change-Id: I691a0d422f4d22065d4d686be190efaeda0b97d5
Reviewed-on: https://chromium-review.googlesource.com/890065Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532354}

third_party/WebKit/Source/core/css/CSSIdentifierValue.cpp

@@ -51,6 +51,7 @@ CSSIdentifierValue::CSSIdentifierValue(const Length& length)
       break;
     case kExtendToZoom:
       value_id_ = CSSValueInternalExtendToZoom;
+      break;
     case kPercent:
     case kFixed:
     case kCalculated:

third_party/WebKit/Source/core/css/RuleFeatureSet.cpp

@@ -881,7 +881,7 @@ RuleFeatureSet::SelectorPreMatch RuleFeatureSet::CollectFeaturesFromSelector(
           return kSelectorNeverMatches;
         }
         found_host_pseudo = true;
-      // fall through.
+        FALLTHROUGH;
       default:
         if (const CSSSelectorList* selector_list = current->SelectorList()) {
           for (const CSSSelector* sub_selector = selector_list->First();

third_party/WebKit/Source/core/css/StyleSheetContents.cpp

@@ -530,6 +530,7 @@ static bool ChildRulesHaveFailedOrCanceledSubresources(
       case StyleRuleBase::kImport:
       case StyleRuleBase::kNamespace:
         NOTREACHED();
+        break;
       case StyleRuleBase::kPage:
       case StyleRuleBase::kKeyframes:
       case StyleRuleBase::kKeyframe:

third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp

@@ -228,6 +228,7 @@ CSSNumericValue* CSSNumericValue::parse(const String& css_text,
         DCHECK(calc_value->ExpressionNode());
         return CalcToNumericValue(*calc_value->ExpressionNode());
       }
+      break;
     default:
       break;
   }

third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp

@@ -59,7 +59,8 @@ CSSSkew* CSSSkew::FromCSSValue(const CSSFunctionValue& value) {
         return CSSSkew::Create(CSSNumericValue::FromCSSValue(x_value),
                                CSSNumericValue::FromCSSValue(y_value));
       }
-    // Else fall through; skew(ax) == skewX(ax).
+      // Else fall through; skew(ax) == skewX(ax).
+      FALLTHROUGH;
     case CSSValueSkewX:
       DCHECK_EQ(value.length(), 1U);
       return CSSSkew::Create(

third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

@@ -438,7 +438,7 @@ bool CSSParserImpl::ConsumeRuleList(CSSParserTokenStream& stream,
           stream.UncheckedConsume();
           continue;
         }
-      // fallthrough
+        FALLTHROUGH;
       default:
         rule = ConsumeQualifiedRule(stream, allowed_rules);
         break;

third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

@@ -162,7 +162,7 @@ bool CSSParserToken::operator==(const CSSParserToken& other) const {
     case kHashToken:
       if (hash_token_type_ != other.hash_token_type_)
         return false;
-    // fallthrough
+      FALLTHROUGH;
     case kIdentToken:
     case kFunctionToken:
     case kStringToken:
@@ -171,7 +171,7 @@ bool CSSParserToken::operator==(const CSSParserToken& other) const {
     case kDimensionToken:
       if (!ValueDataCharRawEqual(other))
         return false;
-    // fallthrough
+      FALLTHROUGH;
     case kNumberToken:
     case kPercentageToken:
       return numeric_sign_ == other.numeric_sign_ &&

third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

@@ -301,7 +301,7 @@ CSSPrimitiveValue* ConsumeLength(CSSParserTokenRange& range,
       case CSSPrimitiveValue::UnitType::kQuirkyEms:
         if (css_parser_mode != kUASheetMode)
           return nullptr;
-      /* fallthrough intentional */
+        FALLTHROUGH;
       case CSSPrimitiveValue::UnitType::kEms:
       case CSSPrimitiveValue::UnitType::kRems:
       case CSSPrimitiveValue::UnitType::kChs:

third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

@@ -531,6 +531,7 @@ std::unique_ptr<CSSParserSelector> CSSSelectorParser::ConsumePseudo(
     case CSSSelector::kPseudoMatches:
       if (!RuntimeEnabledFeatures::CSSMatchesEnabled())
         break;
+      FALLTHROUGH;
     case CSSSelector::kPseudoHost:
     case CSSSelector::kPseudoHostContext:
     case CSSSelector::kPseudoAny:
@@ -675,6 +676,7 @@ CSSSelector::MatchType CSSSelectorParser::ConsumeAttributeMatch(
     case kDelimiterToken:
       if (token.Delimiter() == '=')
         return CSSSelector::kAttributeExact;
+      FALLTHROUGH;
     default:
       failed_parsing_ = true;
       return CSSSelector::kAttributeExact;

third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

@@ -109,7 +109,8 @@ bool SizesCalcParser::CalcToReversePolishNotation(CSSParserTokenRange range) {
       case kFunctionToken:
         if (!EqualIgnoringASCIICase(token.Value(), "calc"))
           return false;
-      // "calc(" is the same as "("
+        // "calc(" is the same as "("
+        FALLTHROUGH;
       case kLeftParenthesisToken:
         // If the token is a left parenthesis, then push it onto the stack.
         stack.push_back(token);
@@ -137,6 +138,7 @@ bool SizesCalcParser::CalcToReversePolishNotation(CSSParserTokenRange range) {
         break;
       case kCommentToken:
         NOTREACHED();
+        FALLTHROUGH;
       case kCDOToken:
       case kCDCToken:
       case kAtKeywordToken:

third_party/WebKit/Source/core/css/properties/longhands/WebkitTextEmphasisStyleCustom.cpp

@@ -63,7 +63,7 @@ const CSSValue* WebkitTextEmphasisStyle::CSSValueFromComputedStyleInternal(
       return CSSStringValue::Create(style.TextEmphasisCustomMark());
     case TextEmphasisMark::kAuto:
       NOTREACHED();
-    // Fall through
+      FALLTHROUGH;
     case TextEmphasisMark::kDot:
     case TextEmphasisMark::kCircle:
     case TextEmphasisMark::kDoubleCircle:

third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp

@@ -80,6 +80,7 @@ AtomicString FontBuilder::GenericFontFamilyName(
   switch (generic_family) {
     default:
       NOTREACHED();
+      FALLTHROUGH;
     case FontDescription::kNoFamily:
       return AtomicString();
     case FontDescription::kStandardFamily:

third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -1280,6 +1280,7 @@ ShadowData StyleBuilderConverter::ConvertShadow(
         switch (value_id) {
           case CSSValueInvalid:
             NOTREACHED();
+            FALLTHROUGH;
           case CSSValueInternalQuirkInherit:
           case CSSValueWebkitLink:
           case CSSValueWebkitActivelink:

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -778,6 +778,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyContent(
       switch (ToCSSIdentifierValue(*item).GetValueID()) {
         default:
           NOTREACHED();
+          FALLTHROUGH;
         case CSSValueOpenQuote:
           quote_type = QuoteType::kOpen;
           break;

third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

@@ -55,6 +55,7 @@ static TransformOperation::OperationType GetTransformOperationType(
   switch (type) {
     default:
       NOTREACHED();
+      FALLTHROUGH;
     case CSSValueScale:
       return TransformOperation::kScale;
     case CSSValueScaleX: