Commit 256a5d1f authored by Alexei Svitkine's avatar Alexei Svitkine Committed by Commit Bot

Remove a number of high-use metrics from UKM's UseCounter metric.

All of these are above the guidance at the top of ukm_features.cc:
"e.g. <1% of page views" - verified on Windows and Android
stable.

The guidance is there because UKM's sampling is on a per event
basis, so individual enum entries can't be sampled at different
rates. If data in UKM still needs to be collected for these,
they can be added as their own dedicated UKM events and thus
could be sampled appropriately.

Bug: 1129061
Change-Id: Id3087b51eb3af80679026444dc6e4c1aa814d1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414917Reviewed-by: default avatarRamin Halavati <rhalavati@chromium.org>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Reviewed-by: default avatarJason Chase <chasej@chromium.org>
Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
Reviewed-by: default avatarMichael Crouse <mcrouse@chromium.org>
Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Reviewed-by: default avatarRick Byers <rbyers@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809129}
parent 026a583e
...@@ -40,7 +40,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() { ...@@ -40,7 +40,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
WebFeature::kMixedContentPlugin, WebFeature::kMixedContentPlugin,
WebFeature::kOpenerNavigationWithoutGesture, WebFeature::kOpenerNavigationWithoutGesture,
WebFeature::kUsbRequestDevice, WebFeature::kUsbRequestDevice,
WebFeature::kXMLHttpRequestSynchronous,
WebFeature::kXMLHttpRequestSynchronousInMainFrame, WebFeature::kXMLHttpRequestSynchronousInMainFrame,
WebFeature::kXMLHttpRequestSynchronousInCrossOriginSubframe, WebFeature::kXMLHttpRequestSynchronousInCrossOriginSubframe,
WebFeature::kXMLHttpRequestSynchronousInSameOriginSubframe, WebFeature::kXMLHttpRequestSynchronousInSameOriginSubframe,
...@@ -59,14 +58,14 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() { ...@@ -59,14 +58,14 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
WebFeature::kCredentialManagerGetPublicKeyCredentialSuccess, WebFeature::kCredentialManagerGetPublicKeyCredentialSuccess,
WebFeature::kU2FCryptotokenRegister, WebFeature::kU2FCryptotokenRegister,
WebFeature::kU2FCryptotokenSign, WebFeature::kU2FCryptotokenSign,
WebFeature::kV8AudioContext_Constructor, // TODO(crbug.com/1129465): The below four use counters have high
// usage, but are expected to be deprecated in several milestones.
WebFeature::kElementAttachShadow, WebFeature::kElementAttachShadow,
WebFeature::kElementAttachShadowOpen, WebFeature::kElementAttachShadowOpen,
WebFeature::kElementAttachShadowClosed, WebFeature::kElementAttachShadowClosed,
WebFeature::kCustomElementRegistryDefine, WebFeature::kCustomElementRegistryDefine,
WebFeature::kTextToSpeech_Speak, WebFeature::kTextToSpeech_Speak,
WebFeature::kTextToSpeech_SpeakDisallowedByAutoplay, WebFeature::kTextToSpeech_SpeakDisallowedByAutoplay,
WebFeature::kCSSEnvironmentVariable,
WebFeature::kCSSEnvironmentVariable_SafeAreaInsetTop, WebFeature::kCSSEnvironmentVariable_SafeAreaInsetTop,
WebFeature::kCSSEnvironmentVariable_SafeAreaInsetLeft, WebFeature::kCSSEnvironmentVariable_SafeAreaInsetLeft,
WebFeature::kCSSEnvironmentVariable_SafeAreaInsetRight, WebFeature::kCSSEnvironmentVariable_SafeAreaInsetRight,
...@@ -85,8 +84,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() { ...@@ -85,8 +84,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
WebFeature::kDocumentDomainEnabledCrossOriginAccess, WebFeature::kDocumentDomainEnabledCrossOriginAccess,
WebFeature::kCursorImageGT32x32, WebFeature::kCursorImageGT32x32,
WebFeature::kCursorImageLE32x32, WebFeature::kCursorImageLE32x32,
WebFeature::kHistoryPushState,
WebFeature::kHistoryReplaceState,
WebFeature::kCursorImageGT64x64, WebFeature::kCursorImageGT64x64,
WebFeature::kAdClick, WebFeature::kAdClick,
WebFeature::kUpdateWithoutShippingOptionOnShippingAddressChange, WebFeature::kUpdateWithoutShippingOptionOnShippingAddressChange,
...@@ -104,7 +101,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() { ...@@ -104,7 +101,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
WebFeature::kMediaCapabilitiesDecodingInfoWithKeySystemConfig, WebFeature::kMediaCapabilitiesDecodingInfoWithKeySystemConfig,
WebFeature::kTextFragmentAnchor, WebFeature::kTextFragmentAnchor,
WebFeature::kTextFragmentAnchorMatchFound, WebFeature::kTextFragmentAnchorMatchFound,
WebFeature::kCookieNoSameSite,
WebFeature::kCookieInsecureAndSameSiteNone, WebFeature::kCookieInsecureAndSameSiteNone,
WebFeature::kCookieStoreAPI, WebFeature::kCookieStoreAPI,
WebFeature::kDeviceOrientationSecureOrigin, WebFeature::kDeviceOrientationSecureOrigin,
...@@ -125,13 +121,8 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() { ...@@ -125,13 +121,8 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
WebFeature::kLazyLoadFrameLoadingAttributeEager, WebFeature::kLazyLoadFrameLoadingAttributeEager,
WebFeature::kLazyLoadImageLoadingAttributeLazy, WebFeature::kLazyLoadImageLoadingAttributeLazy,
WebFeature::kLazyLoadImageLoadingAttributeEager, WebFeature::kLazyLoadImageLoadingAttributeEager,
WebFeature::kRequestedFileSystemTemporary,
WebFeature::kRequestedFileSystemPersistent, WebFeature::kRequestedFileSystemPersistent,
WebFeature::kWebOTP, WebFeature::kWebOTP,
WebFeature::kSrcsetWDescriptor,
WebFeature::kSrcsetXDescriptor,
WebFeature::kRequestFileSystem,
WebFeature::kBaseElement,
WebFeature::kBaseWithCrossOriginHref, WebFeature::kBaseWithCrossOriginHref,
WebFeature::kWakeLockAcquireScreenLock, WebFeature::kWakeLockAcquireScreenLock,
WebFeature::kWakeLockAcquireSystemLock, WebFeature::kWakeLockAcquireSystemLock,
...@@ -158,8 +149,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() { ...@@ -158,8 +149,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
WebFeature::kThirdPartyFileSystem, WebFeature::kThirdPartyFileSystem,
WebFeature::kThirdPartyIndexedDb, WebFeature::kThirdPartyIndexedDb,
WebFeature::kThirdPartyCacheStorage, WebFeature::kThirdPartyCacheStorage,
WebFeature::kThirdPartyLocalStorage,
WebFeature::kThirdPartySessionStorage,
WebFeature::kOverlayPopup, WebFeature::kOverlayPopup,
WebFeature::kOverlayPopupAd, WebFeature::kOverlayPopupAd,
WebFeature::kTrustTokenXhr, WebFeature::kTrustTokenXhr,
......
...@@ -2968,12 +2968,15 @@ be describing additional metrics about the same event. ...@@ -2968,12 +2968,15 @@ be describing additional metrics about the same event.
</event> </event>
<event name="Blink.UseCounter"> <event name="Blink.UseCounter">
<owner>loonybear@chromium.org</owner> <owner>chasej@chromium.org</owner>
<summary> <summary>
Collects data for a subset of UseCounter features. When UMA UseCounter data Collects data for a subset of UseCounter features where UMA UseCounter data
shows a behaviour that is rare but too common to blindly change. This metric shows a behaviour that is rare but too common to blindly change. This metric
should be used to reason about whether a breaking change is acceptable or should be used to reason about whether a breaking change is acceptable or
not. not.
Note: In M87, a number of use counters were removed from UKM reporting due
to being reported too frequently (high proportion across page loads).
</summary> </summary>
<metric name="Feature" enum="FeatureObserver"> <metric name="Feature" enum="FeatureObserver">
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment