Commit 2578ea19 authored by erg@chromium.org's avatar erg@chromium.org

Revert of linux_aura: Attempt to green the official builder by reverting...

Revert of linux_aura: Attempt to green the official builder by reverting unwind support. (https://codereview.chromium.org/141013009/)

Reason for revert:
Didn't actually help with the build failures on Google Chrome Linux.

Original issue's description:
> linux_aura: Attempt to green the official builder by reverting unwind support.
> 
> This effectively reverts in r243919 and r244331 in a desperate attempt
> to fix the tree.
> 
> Build fail output:
> 
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
> Staging common install files in '/tmp/rpm.build.XtJRbJ'...
> eu-strip: while computing checksum for debug information: Invalid argument
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
> Staging common install files in '/tmp/rpm.build.t4jNp4'...
> eu-strip: while computing checksum for debug information: Invalid argument
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
> Staging common install files in '/tmp/deb.build.CxnH9l'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
> Staging common install files in '/tmp/deb.build.9Zyie1'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
> Staging common install files in '/tmp/deb.build.xUB39X'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
> Staging common install files in '/tmp/rpm.build.aN0PGV'...
> eu-strip: while computing checksum for debug information: Invalid argument
> ../out/Release/chrome, section '.eh_frame': the call frame entry at offset 0x18 uses a DWARF expression to describe how to recover register '.cfa',  but this translator cannot yet translate DWARF expressions to Breakpad postfix expressions
> ninja: build stopped: subcommand failed.
> 
> BUG=180975
> TBR=spang@chromium.org, stip@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245421

TBR=spang@chromium.org,stip@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=180975

Review URL: https://codereview.chromium.org/141273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245428 0039d316-1c4b-4281-b951-d872f2087c98
parent dcc7608d
......@@ -1134,6 +1134,9 @@
'linux_strip_binary%': 0,
# Strip the test binaries needed for Linux reliability tests.
'linux_strip_reliability_tests%': 0,
# If we want stack unwind support for backtrace().
'debug_unwind_tables%': 1,
'release_unwind_tables%': 1,
# Enable TCMalloc.
'linux_use_tcmalloc%': 1,
......@@ -1318,6 +1321,10 @@
# symbols from official builds.
['(branding=="Chrome" and buildtype=="Official")', {
'linux_dump_symbols%': 1,
# Omit unwind support in official release builds to save space. We
# can use breakpad for these builds.
'release_unwind_tables%': 0,
}],
],
}], # os_posix==1 and OS!="mac" and OS!="ios"
......@@ -3039,6 +3046,11 @@
'-Wl,--no-as-needed',
],
}],
['debug_unwind_tables==1', {
'cflags': ['-funwind-tables'],
}, {
'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
}],
],
},
'Release_Base': {
......@@ -3110,13 +3122,10 @@
}],
],
}],
# Can be omitted to reduce output size. Does not seem to affect
# crash reporting.
['target_arch=="ia32"', {
'cflags': [
'-fno-unwind-tables',
'-fno-asynchronous-unwind-tables',
],
['release_unwind_tables==1', {
'cflags': ['-funwind-tables'],
}, {
'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
}],
],
},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment