Commit 258b4c27 authored by Helen Li's avatar Helen Li Committed by Commit Bot

Add a DCHECK in mojo/public/cpp/system/handle.h

Bug: 821030
Change-Id: Iec0c32ba9cc7cb0335e7c320179e2689ab59bba6
Reviewed-on: https://chromium-review.googlesource.com/957918Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550477}
parent c64ff31d
...@@ -103,15 +103,4 @@ TEST_F(ClipboardHostImplTest, ImageSizeOverflows32BitRowBytes) { ...@@ -103,15 +103,4 @@ TEST_F(ClipboardHostImplTest, ImageSizeOverflows32BitRowBytes) {
clipboard()->GetSequenceNumber(ui::CLIPBOARD_TYPE_COPY_PASTE)); clipboard()->GetSequenceNumber(ui::CLIPBOARD_TYPE_COPY_PASTE));
} }
TEST_F(ClipboardHostImplTest, InvalidSharedMemoryHandle) {
mojo::ScopedSharedBufferHandle shared_memory;
CallWriteImage(gfx::Size(5, 5), std::move(shared_memory), 0);
uint64_t sequence_number =
clipboard()->GetSequenceNumber(ui::CLIPBOARD_TYPE_COPY_PASTE);
CallCommitWrite();
EXPECT_EQ(sequence_number,
clipboard()->GetSequenceNumber(ui::CLIPBOARD_TYPE_COPY_PASTE));
}
} // namespace content } // namespace content
...@@ -94,7 +94,10 @@ class ScopedHandleBase { ...@@ -94,7 +94,10 @@ class ScopedHandleBase {
} }
const HandleType& get() const { return handle_; } const HandleType& get() const { return handle_; }
const HandleType* operator->() const { return &handle_; } const HandleType* operator->() const {
DCHECK(handle_.is_valid());
return &handle_;
}
template <typename PassedHandleType> template <typename PassedHandleType>
static ScopedHandleBase<HandleType> From( static ScopedHandleBase<HandleType> From(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment