Commit 258b761b authored by ericrk's avatar ericrk Committed by Commit bot

Remove non-quiescent sites from power.top_25

Certain sites in the top_25 pageset are non-quiescent, which makes them
non-suitable for the power metrics. We had already excluded one, but
two others were causing issues. Update the filter to remove these as
well.

BUG=550537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2384673002
Cr-Commit-Position: refs/heads/master@{#422558}
parent c2897611
......@@ -147,21 +147,29 @@ class PowerTop25(perf_benchmark.PerfBenchmark):
return 'power.top_25'
def CreateStorySet(self, _):
# Exclude techcrunch.com. It is not suitable for this benchmark because it
# does not consistently become quiescent within 60 seconds.
stories = self.page_set()
found = next((x for x in stories if 'techcrunch.com' in x.url), None)
if found:
stories.RemoveStory(found)
to_remove = [x for x in stories if self.IsPageNotQuiescent(x.url)]
for story in to_remove:
stories.RemoveStory(story)
return stories
@staticmethod
def IsPageNotQuiescent(page_url):
# Exclude sites not suitable for this benchmark because they do not
# consistently become quiescent within 60 seconds.
non_quiescent_urls = [
'techcrunch.com',
'docs.google.com',
'plus.google.com'
]
return any(url in page_url for url in non_quiescent_urls)
@benchmark.Enabled('mac')
class PowerGpuRasterizationTop25(perf_benchmark.PerfBenchmark):
class PowerGpuRasterizationTop25(PowerTop25):
"""Top 25 quiescent power test with GPU rasterization enabled."""
tag = 'gpu_rasterization'
test = power.QuiescentPower
page_set = page_sets.Top25PageSet
def SetExtraBrowserOptions(self, options):
silk_flags.CustomizeBrowserOptionsForGpuRasterization(options)
......@@ -171,15 +179,6 @@ class PowerGpuRasterizationTop25(perf_benchmark.PerfBenchmark):
def Name(cls):
return 'power.gpu_rasterization.top_25'
def CreateStorySet(self, _):
# Exclude techcrunch.com. It is not suitable for this benchmark because it
# does not consistently become quiescent within 60 seconds.
stories = self.page_set()
found = next((x for x in stories if 'techcrunch.com' in x.url), None)
if found:
stories.RemoveStory(found)
return stories
@benchmark.Enabled('mac')
class PowerScrollingTrivialPage(perf_benchmark.PerfBenchmark):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment