Commit 25924cc5 authored by Yuki Shiino's avatar Yuki Shiino Committed by Commit Bot

base/allocator: Clean up base/BUILD.gn about use_allocator_shim

allocator/allocator_shim_override_cpp_symbols.h and
allocator/allocator_shim_override_libc_symbols.h are not used on
all platforms.  The old BUILD.gn looked confusing as if these
two files are used regardless of platforms.

Moves the two files to platform-specific sections so that it's
clear that the files are platform-dependent.

Change-Id: I9da23cd7377d01b0a9c968224ddea88dd4c67211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461186Reviewed-by: default avatarWill Harris <wfh@chromium.org>
Reviewed-by: default avatarBenoit L <lizeb@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816162}
parent 14b91951
...@@ -1290,19 +1290,23 @@ component("base") { ...@@ -1290,19 +1290,23 @@ component("base") {
"allocator/allocator_shim.cc", "allocator/allocator_shim.cc",
"allocator/allocator_shim.h", "allocator/allocator_shim.h",
"allocator/allocator_shim_internals.h", "allocator/allocator_shim_internals.h",
"allocator/allocator_shim_override_cpp_symbols.h",
"allocator/allocator_shim_override_libc_symbols.h",
] ]
if (is_android) { if (is_android) {
sources += sources += [
[ "allocator/allocator_shim_override_linker_wrapped_symbols.h" ] "allocator/allocator_shim_override_cpp_symbols.h",
"allocator/allocator_shim_override_linker_wrapped_symbols.h",
]
all_dependent_configs += [ "//base/allocator:wrap_malloc_symbols" ] all_dependent_configs += [ "//base/allocator:wrap_malloc_symbols" ]
} }
if (is_apple) { if (is_apple) {
sources += [ "allocator/allocator_shim_override_mac_symbols.h" ] sources += [ "allocator/allocator_shim_override_mac_symbols.h" ]
} }
if (is_chromeos || is_linux) { if (is_chromeos || is_linux) {
sources += [ "allocator/allocator_shim_override_glibc_weak_symbols.h" ] sources += [
"allocator/allocator_shim_override_cpp_symbols.h",
"allocator/allocator_shim_override_glibc_weak_symbols.h",
"allocator/allocator_shim_override_libc_symbols.h",
]
} }
if (is_win) { if (is_win) {
sources += [ sources += [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment