Commit 25c93363 authored by nednguyen's avatar nednguyen Committed by Commit bot

Replace v8 benchmark names with rawstring

Generating benchmark name with code makes it hard to code search for a benchmark.

Review-Url: https://codereview.chromium.org/2752273002
Cr-Commit-Position: refs/heads/master@{#457775}
parent 27885745
......@@ -67,10 +67,6 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
def CreateStorySet(self, options):
return page_sets.SystemHealthStorySet(platform=self.PLATFORM, case='browse')
@classmethod
def Name(cls):
return 'v8.browsing_%s%s' % (cls.PLATFORM, cls.TEST_SUFFIX)
@classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
# TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
......@@ -128,10 +124,6 @@ class _V8RuntimeStatsBrowsingBenchmark(perf_benchmark.PerfBenchmark):
def CreateStorySet(self, options):
return page_sets.SystemHealthStorySet(platform=self.PLATFORM, case='browse')
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_%s%s' % (cls.PLATFORM, cls.TEST_SUFFIX)
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return True
......@@ -159,14 +151,20 @@ class _V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
@benchmark.Owner(emails=['ulan@chromium.org'])
class V8DesktopBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
PLATFORM = 'desktop'
TEST_SUFFIX = ''
@classmethod
def Name(cls):
return 'v8.browsing_desktop'
@benchmark.Owner(emails=['ulan@chromium.org'])
@benchmark.Disabled('reference') # http://crbug.com/628631
class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark):
PLATFORM = 'mobile'
TEST_SUFFIX = ''
@classmethod
def Name(cls):
return 'v8.browsing_mobile'
@benchmark.Disabled('reference') # http://crbug.com/700390
......@@ -174,61 +172,77 @@ class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark):
@benchmark.Owner(emails=['mvstaton@chromium.org'])
class V8DesktopTurboBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
PLATFORM = 'desktop'
TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8DesktopTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableTurbo(options)
@classmethod
def Name(cls):
return 'v8.browsing_desktop_turbo'
@benchmark.Disabled('reference') # http://crbug.com/628631
@benchmark.Disabled('all')
@benchmark.Owner(emails=['mvstaton@chromium.org'])
class V8MobileTurboBrowsingBenchmark(_V8MobileBrowsingBenchmark):
PLATFORM = 'mobile'
TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8MobileTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableTurbo(options)
@classmethod
def Name(cls):
return 'v8.browsing_mobile_turbo'
@benchmark.Disabled('reference') # http://crbug.com/700390
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8DesktopClassicBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
PLATFORM = 'desktop'
TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8DesktopClassicBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableClassic(options)
@classmethod
def Name(cls):
return 'v8.browsing_desktop_classic'
@benchmark.Disabled('reference') # http://crbug.com/628631
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8MobileClassicBrowsingBenchmark(_V8MobileBrowsingBenchmark):
PLATFORM = 'mobile'
TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8MobileClassicBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableClassic(options)
@classmethod
def Name(cls):
return 'v8.browsing_mobile_classic'
@benchmark.Owner(emails=['mythria@chromium.org'])
class V8RuntimeStatsDesktopBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'desktop'
TEST_SUFFIX = ''
@classmethod
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_desktop'
@benchmark.Disabled('reference') # http://crbug.com/700390
@benchmark.Disabled('all')
......@@ -236,7 +250,6 @@ class V8RuntimeStatsDesktopBrowsingBenchmark(
class V8RuntimeStatsDesktopTurboBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'desktop'
TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsDesktopTurboBrowsingBenchmark,
......@@ -247,13 +260,16 @@ class V8RuntimeStatsDesktopTurboBrowsingBenchmark(
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_desktop_turbo'
@benchmark.Disabled('reference') # http://crbug.com/700390
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8RuntimeStatsDesktopClassicBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'desktop'
TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsDesktopClassicBrowsingBenchmark,
......@@ -264,18 +280,26 @@ class V8RuntimeStatsDesktopClassicBrowsingBenchmark(
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_desktop_classic'
@benchmark.Disabled('reference') # http://crbug.com/694658
@benchmark.Owner(emails=['mythria@chromium.org'])
class V8RuntimeStatsMobileBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'mobile'
TEST_SUFFIX = ''
@classmethod
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_mobile'
@benchmark.Disabled('reference') # http://crbug.com/694658
@benchmark.Disabled('all')
......@@ -283,7 +307,6 @@ class V8RuntimeStatsMobileBrowsingBenchmark(
class V8RuntimeStatsMobileTurboBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'mobile'
TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsMobileTurboBrowsingBenchmark,
......@@ -294,13 +317,16 @@ class V8RuntimeStatsMobileTurboBrowsingBenchmark(
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_mobile_turbo'
@benchmark.Disabled('reference') # http://crbug.com/694658
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8RuntimeStatsMobileClassicBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'mobile'
TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsMobileClassicBrowsingBenchmark,
......@@ -310,3 +336,7 @@ class V8RuntimeStatsMobileClassicBrowsingBenchmark(
@classmethod
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
@classmethod
def Name(cls):
return 'v8.runtimestats.browsing_mobile_classic'
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment