[ios] Addressed some TODO left behind in crw refactor

Bug: 956511
Change-Id: I3f64f693d26d0db9f54f84ef7e2a36fa713434d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247764
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779838}

ios/web/navigation/crw_wk_navigation_handler.h

@@ -89,9 +89,8 @@ class WKBackForwardListItemHolder;
 - (instancetype)initWithDelegate:(id<CRWWKNavigationHandlerDelegate>)delegate
     NS_DESIGNATED_INITIALIZER;
 
-// TODO(crbug.com/956511): Change this to readonly when
-// |webViewWebProcessDidCrash| is moved to CRWWKNavigationHandler.
-@property(nonatomic, assign) BOOL webProcessCrashed;
+// Indicates if the webview reported a crash.
+@property(nonatomic, assign, readonly) BOOL webProcessCrashed;
 
 // Pending information for an in-progress page navigation. The lifetime of
 // this object starts at |decidePolicyForNavigationAction| where the info is

ios/web/navigation/crw_wk_navigation_handler.mm

@@ -206,7 +206,7 @@ void ReportOutOfSyncURLInDidStartProvisionalNavigation(
     }
   }
 
-  self.webProcessCrashed = NO;
+  _webProcessCrashed = NO;
   if (self.beingDestroyed) {
     decisionHandler(WKNavigationActionPolicyCancel);
     return;
@@ -1192,7 +1192,7 @@ void ReportOutOfSyncURLInDidStartProvisionalNavigation(
   [self didReceiveWKNavigationDelegateCallback];
 
   _certVerificationErrors->Clear();
-  self.webProcessCrashed = YES;
+  _webProcessCrashed = YES;
   self.webStateImpl->GetWebFramesManagerImpl().RemoveAllWebFrames();
 
   [self.delegate navigationHandlerWebProcessDidCrash:self];
@@ -2456,9 +2456,7 @@ void ReportOutOfSyncURLInDidStartProvisionalNavigation(
                                        originalContext {
   DCHECK(!base::FeatureList::IsEnabled(web::features::kUseJSForErrorPage));
   GURL placeholderURL = CreatePlaceholderUrlForUrl(originalURL);
-  // TODO(crbug.com/956511): Remove this code when NativeContent support is
-  // removed.
-  [self.delegate ensureWebViewCreatedForWebViewHandler:self];
+
   WKWebView* webView = [self.delegate webViewForWebViewHandler:self];
 
   NSURLRequest* request =
@@ -2513,8 +2511,7 @@ void ReportOutOfSyncURLInDidStartProvisionalNavigation(
     currentItem->SetReferrer(referrer);
   }
 
-  // TODO(crbug.com/956511): This shouldn't be called for hash state or
-  // push/replaceState.
+  // TODO(crbug.com/956511): This shouldn't be called for push/replaceState.
   [self resetDocumentSpecificState];
 
   [self.delegate navigationHandlerDidStartLoading:self];