MemoryInfra: Fix AutoComplete provider and enable on background mode

There could be multiple providers. So, each must create allocator dumps
with distinct names. Refer notes on GetOrCreateAllocatorDump.
Group autocomplete and in_memory_url_index dumps under different child
dumps for easier collection of metrics.

BUG=803822
TBR=mpearson@chromium.org

Change-Id: I872491bb1496572600fc6b6f87d9198a76eea8c7
Reviewed-on: https://chromium-review.googlesource.com/961263
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543017}

base/trace_event/memory_infra_background_whitelist.cc

@@ -20,6 +20,7 @@ namespace {
 // little processor and memory overhead.
 const char* const kDumpProviderWhitelist[] = {
     "android::ResourceManagerImpl",
+    "AutocompleteController",
     "BlinkGC",
     "BlinkObjectCounters",
     "ClientDiscardableSharedMemoryManager",
@@ -202,7 +203,8 @@ const char* const kAllocatorDumpNameWhitelist[] = {
     "net/url_request_context/unknown/0x?/http_cache/memory_backend",
     "net/url_request_context/unknown/0x?/http_cache/simple_backend",
     "net/url_request_context/unknown/0x?/http_network_session",
-    "omnibox/in_memory_url_index_0x?",
+    "omnibox/autocomplete_controller/0x?",
+    "omnibox/in_memory_url_index/0x?",
     "web_cache/Image_resources",
     "web_cache/CSS stylesheet_resources",
     "web_cache/Script_resources",

chrome/browser/autocomplete/autocomplete_browsertest.cc

@@ -355,11 +355,13 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, FocusSearch) {
 
 IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, MemoryTracing) {
   auto* in_memory_url_index = InMemoryURLIndexFactory::GetForProfile(profile());
+  auto* autocomplete_controller = GetAutocompleteController();
 
   const std::vector<std::string> expected_names{
-      base::StringPrintf("omnibox/in_memory_url_index_0x%" PRIXPTR,
+      base::StringPrintf("omnibox/in_memory_url_index/0x%" PRIXPTR,
                          reinterpret_cast<uintptr_t>(in_memory_url_index)),
-      "omnibox/autocomplete_controller"};
+      base::StringPrintf("omnibox/autocomplete_controller/0x%" PRIXPTR,
+                         reinterpret_cast<uintptr_t>(autocomplete_controller))};
 
   auto OnMemoryDumpDone =
       [](const std::vector<std::string>& expected_names, base::OnceClosure quit,
@@ -377,7 +379,7 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, MemoryTracing) {
   base::RunLoop run_loop;
   base::trace_event::MemoryDumpRequestArgs args{
       1 /* dump_guid*/, base::trace_event::MemoryDumpType::EXPLICITLY_TRIGGERED,
-      base::trace_event::MemoryDumpLevelOfDetail::DETAILED};
+      base::trace_event::MemoryDumpLevelOfDetail::BACKGROUND};
 
   base::trace_event::MemoryDumpManager::GetInstance()->CreateProcessDump(
       args, base::BindRepeating(OnMemoryDumpDone, expected_names,

components/omnibox/browser/autocomplete_controller.cc

@@ -4,6 +4,8 @@
 
 #include "components/omnibox/browser/autocomplete_controller.h"
 
+#include <inttypes.h>
+
 #include <cstddef>
 #include <memory>
 #include <numeric>
@@ -760,8 +762,9 @@ bool AutocompleteController::OnMemoryDump(
   res += input_.EstimateMemoryUsage();
   res += result_.EstimateMemoryUsage();
 
-  auto* dump = process_memory_dump->GetOrCreateAllocatorDump(
-      "omnibox/autocomplete_controller");
+  auto* dump = process_memory_dump->CreateAllocatorDump(
+      base::StringPrintf("omnibox/autocomplete_controller/0x%" PRIXPTR,
+                         reinterpret_cast<uintptr_t>(this)));
   dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
                   base::trace_event::MemoryAllocatorDump::kUnitsBytes, res);
   return true;

components/omnibox/browser/in_memory_url_index.cc

@@ -225,7 +225,7 @@ bool InMemoryURLIndex::OnMemoryDump(
   res += sizeof(URLIndexPrivateData) + private_data_->EstimateMemoryUsage();
 
   const std::string dump_name =
-      base::StringPrintf("omnibox/in_memory_url_index_0x%" PRIXPTR,
+      base::StringPrintf("omnibox/in_memory_url_index/0x%" PRIXPTR,
                          reinterpret_cast<uintptr_t>(this));
   auto* dump = process_memory_dump->CreateAllocatorDump(dump_name);
   dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,