Commit 25f5e388 authored by Chris Harrelson's avatar Chris Harrelson Committed by Commit Bot

Stop re-computing compositing inputs for scrollers with sticky

descendants.

This was added in revision 548120 because at the time paint
offset baked in sticky position. This was since fixed in revision
590578 that factored sticky position into a transform paint
property node rather than paint offset.

All that is required is to re-compute paint properties for the
scroller and all sticky descendants, in order to update the scroll
offset and sticky transform offset. The latter is accomplished
by a call to PLSA::InvalidatePaintForStickyDescendants() in
PLSA::InvalidatePaintForScrollOffsetChange().

Bug: 895109

Change-Id: Ied7ef8fd15db4f5c3d546f0f06f1adf3cf1e26c8
Reviewed-on: https://chromium-review.googlesource.com/c/1345031Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610305}
parent c16f673b
...@@ -2161,11 +2161,6 @@ void PaintLayerScrollableArea::UpdateCompositingLayersAfterScroll() { ...@@ -2161,11 +2161,6 @@ void PaintLayerScrollableArea::UpdateCompositingLayersAfterScroll() {
kCompositingUpdateAfterGeometryChange); kCompositingUpdateAfterGeometryChange);
} }
// Sticky constraints and paint property nodes need to be updated
// to the new sticky locations.
if (HasStickyDescendants())
InvalidateAllStickyConstraints();
// If we have fixed elements and we scroll the root layer we might // If we have fixed elements and we scroll the root layer we might
// change compositing since the fixed elements might now overlap a // change compositing since the fixed elements might now overlap a
// composited layer. // composited layer.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment