Succeed only once in terminal private api settingsTest()

`chrome.test.callbackPass()` call `chrome.test.succeed()` automatically,
so `settingsTest()` was actually calling `succeed()` twice. Also,
calling `callbackPass()` inside a callback function seems to be a bad
idea. For example, the test could succeed prematurely if the callback is
not called in time.

Change-Id: I6d46337db933e515551a1c172ad072ac92abe9bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522715
Auto-Submit: Jason Lin <lxj@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825223}

chrome/test/data/extensions/api_test/terminal/component_extension/test.js

@@ -269,20 +269,23 @@ chrome.test.runTests([
       chrome.test.assertEq('v', settings['k']);
 
       // 4. Get settings - {'k': 'v'}.
-      chrome.terminalPrivate.getSettings(
-          chrome.test.callbackPass((settings) => {
-            chrome.test.assertEq(1, Object.keys(settings).length);
-            chrome.test.assertEq('v', settings['k']);
-            chrome.test.succeed();
-          }));
+      chrome.terminalPrivate.getSettings((settings) => {
+        chrome.test.assertNoLastError();
+        chrome.test.assertEq(1, Object.keys(settings).length);
+        chrome.test.assertEq('v', settings['k']);
+        chrome.test.succeed();
+      });
     });
 
     // 1. Get settings - {}.
-    chrome.terminalPrivate.getSettings(chrome.test.callbackPass((settings) => {
+    chrome.terminalPrivate.getSettings((settings) => {
+      chrome.test.assertNoLastError();
       chrome.test.assertEq(0, Object.keys(settings).length);
 
       // 2. Set {'k': 'v'}.
-      chrome.terminalPrivate.setSettings({k: 'v'}, chrome.test.callbackPass());
-    }));
-  }
+      chrome.terminalPrivate.setSettings(
+          {k: 'v'}, () => chrome.test.assertNoLastError());
+    });
+  },
+
 ]);