Commit 26309371 authored by bashi's avatar bashi Committed by Commit bot

bindings: Stop using forward declarations for typed array in union containers

Typed arrays in blink (e.g. DOMFloat32Array) are typedef of DOMTypedArray<T, U>
so using forward declarations causes conflicts. Stop using forward
declarations for typed arrays in union containers. Instead, include
headers directly.

BUG=671755

Review-Url: https://codereview.chromium.org/2559323004
Cr-Commit-Position: refs/heads/master@{#437717}
parent bee6a64b
......@@ -121,7 +121,7 @@ def _update_includes_and_forward_decls(member, interface_info):
cpp_includes.update(interface_info.get(
'dependencies_include_paths', []))
# We need complete types for IDL dictionaries in union containers.
if member.is_dictionary:
if member.is_dictionary or member.is_typed_array:
header_includes.update(member.includes_for_type())
else:
cpp_includes.update(member.includes_for_type())
......
......@@ -9,10 +9,7 @@
#include "TestInterface2OrUint8Array.h"
#include "bindings/core/v8/ToV8.h"
#include "bindings/core/v8/V8ArrayBufferView.h"
#include "bindings/core/v8/V8TestInterface2.h"
#include "bindings/core/v8/V8Uint8Array.h"
#include "core/dom/FlexibleArrayBufferView.h"
namespace blink {
......
......@@ -11,13 +11,15 @@
#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/V8ArrayBufferView.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8Uint8Array.h"
#include "core/CoreExport.h"
#include "core/dom/FlexibleArrayBufferView.h"
#include "platform/heap/Handle.h"
namespace blink {
class DOMUint8Array;
class TestInterface2;
class CORE_EXPORT TestInterface2OrUint8Array final {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment