Introduce new functions with profile param in IdentityServicesProvider.

This CL adds getter functions for identity manager, sign-in manager and
account tracker service with profile parameter, instead of using
functions with always regular profile. After this CL, the caller
classes of IdentityServicesProvider will be able to get services for
the given profile.

Bug: 1041781
Change-Id: I324466c3b0700775434d2e2c6a8eaeffcc4b84c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241973Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779214}

chrome/android/java/src/org/chromium/chrome/browser/signin/IdentityServicesProvider.java

@@ -33,39 +33,70 @@ public class IdentityServicesProvider {
         sIdentityServicesProvider = provider;
     }
 
-    /** Getter for {@link IdentityManager} instance. */
-    public IdentityManager getIdentityManager() {
+    /**
+     * Getter for {@link IdentityManager} instance for given profile.
+     * @param profile The profile to get regarding identity manager.
+     * @return a {@link IdentityManager} instance.
+     */
+    public IdentityManager getIdentityManager(Profile profile) {
         ThreadUtils.assertOnUiThread();
-        // TODO(https://crbug.com/1041781): Use the current profile (i.e., regular profile or
-        // incognito profile) instead of always using regular profile.
-        IdentityManager result = IdentityServicesProviderJni.get().getIdentityManager(
-                Profile.getLastUsedRegularProfile());
+        IdentityManager result = IdentityServicesProviderJni.get().getIdentityManager(profile);
         assert result != null;
         return result;
     }
 
-    /** Getter for {@link AccountTrackerService} instance. */
-    public AccountTrackerService getAccountTrackerService() {
+    /**
+     * Getter for {@link IdentityManager} instance.
+     * Deprecated, use {@link IdentityServicesProvider#getIdentityManager(Profile)} instead.
+     */
+    @Deprecated
+    public IdentityManager getIdentityManager() {
+        return getIdentityManager(Profile.getLastUsedRegularProfile());
+    }
+
+    /**
+     * Getter for {@link AccountTrackerService} instance for given profile.
+     * @param profile The profile to get regarding account tracker service.
+     * @return a {@link AccountTrackerService} instance.
+     */
+    public AccountTrackerService getAccountTrackerService(Profile profile) {
         ThreadUtils.assertOnUiThread();
-        // TODO(https://crbug.com/1041781): Use the current profile (i.e., regular profile or
-        // incognito profile) instead of always using regular profile.
-        AccountTrackerService result = IdentityServicesProviderJni.get().getAccountTrackerService(
-                Profile.getLastUsedRegularProfile());
+        AccountTrackerService result =
+                IdentityServicesProviderJni.get().getAccountTrackerService(profile);
         assert result != null;
         return result;
     }
 
-    /** Getter for {@link SigninManager} instance. */
-    public SigninManager getSigninManager() {
+    /**
+     * Getter for {@link AccountTrackerService} instance.
+     * Deprecated, use {@link IdentityServicesProvider#getAccountTrackerService(Profile)} instead.
+     */
+    @Deprecated
+    public AccountTrackerService getAccountTrackerService() {
+        return getAccountTrackerService(Profile.getLastUsedRegularProfile());
+    }
+
+    /**
+     * Getter for {@link SigninManager} instance for given profile.
+     * @param profile The profile to get regarding sign-in manager.
+     * @return a {@link SigninManager} instance.
+     */
+    public SigninManager getSigninManager(Profile profile) {
         ThreadUtils.assertOnUiThread();
-        // TODO(https://crbug.com/1041781): Use the current profile (i.e., regular profile or
-        // incognito profile) instead of always using regular profile.
-        SigninManager result = IdentityServicesProviderJni.get().getSigninManager(
-                Profile.getLastUsedRegularProfile());
+        SigninManager result = IdentityServicesProviderJni.get().getSigninManager(profile);
         assert result != null;
         return result;
     }
 
+    /**
+     * Getter for {@link SigninManager} instance.
+     * Deprecated, use {@link IdentityServicesProvider#getSigninManager(Profile)} instead.
+     */
+    @Deprecated
+    public SigninManager getSigninManager() {
+        return getSigninManager(Profile.getLastUsedRegularProfile());
+    }
+
     @NativeMethods
     interface Natives {
         IdentityManager getIdentityManager(Profile profile);