Commit 26379e79 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Remove scroll_types.h and kurl.h from element.h

PointerID was defined indirectly through scroll_types.h. This CL splits
out the PointerID definition from web_pointer_properties.h, and
element.h includes the new header.

This CL reduces estimated pre-processed size of element.h from
3.11MB to 2.37MB.

Bug: 242216
Change-Id: Idfd35d73d315a9bdcc89938fb42915a41832877c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775885
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691957}
parent 36491bfe
......@@ -173,6 +173,7 @@ source_set("blink_headers") {
"platform/modules/webrtc/webrtc_source.h",
"platform/modules/webrtc/webrtc_video_frame_adapter.h",
"platform/platform.h",
"platform/pointer_id.h",
"platform/pointer_properties.h",
"platform/scheduler/web_rail_mode_observer.h",
"platform/scheduler/web_render_widget_scheduling_state.h",
......
// Copyright (c) 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef THIRD_PARTY_BLINK_PUBLIC_PLATFORM_POINTER_ID_H_
#define THIRD_PARTY_BLINK_PUBLIC_PLATFORM_POINTER_ID_H_
#include <cstdint>
namespace blink {
// TODO(tkent): Rename this to WebPointerID to follow the naming convention
// in blink/public/.
using PointerId = std::int32_t;
} // namespace blink
#endif // THIRD_PARTY_BLINK_PUBLIC_PLATFORM_POINTER_ID_H_
......@@ -5,16 +5,14 @@
#ifndef THIRD_PARTY_BLINK_PUBLIC_PLATFORM_WEB_POINTER_PROPERTIES_H_
#define THIRD_PARTY_BLINK_PUBLIC_PLATFORM_WEB_POINTER_PROPERTIES_H_
#include "third_party/blink/public/platform/pointer_id.h"
#include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/platform/web_float_point.h"
#include <cstdint>
#include <limits>
namespace blink {
using PointerId = int32_t;
// This class encapsulates the properties that are common between mouse and
// pointer events and touch points as we transition towards the unified pointer
// event model.
......
......@@ -25,6 +25,7 @@
#ifndef THIRD_PARTY_BLINK_RENDERER_CORE_DOM_ELEMENT_H_
#define THIRD_PARTY_BLINK_RENDERER_CORE_DOM_ELEMENT_H_
#include "third_party/blink/public/platform/pointer_id.h"
#include "third_party/blink/public/platform/web_focus_type.h"
#include "third_party/blink/renderer/core/animation/animatable.h"
#include "third_party/blink/renderer/core/core_export.h"
......@@ -38,10 +39,8 @@
#include "third_party/blink/renderer/core/dom/whitespace_attacher.h"
#include "third_party/blink/renderer/core/html/focus_options.h"
#include "third_party/blink/renderer/core/html_names.h"
#include "third_party/blink/renderer/core/scroll/scroll_types.h"
#include "third_party/blink/renderer/core/trustedtypes/trusted_types_util.h"
#include "third_party/blink/renderer/platform/heap/handle.h"
#include "third_party/blink/renderer/platform/weborigin/kurl.h"
#include "third_party/blink/renderer/platform/wtf/hash_set.h"
namespace blink {
......@@ -64,6 +63,7 @@ class ElementIntersectionObserverData;
class ElementRareData;
class ExceptionState;
class FloatQuad;
class FloatSize;
class FocusOptions;
class Image;
class InputDeviceCapabilities;
......@@ -95,6 +95,8 @@ enum class CSSPropertyID;
enum class CSSValueID;
enum class DisplayLockLifecycleTarget;
using ScrollOffset = FloatSize;
enum SpellcheckAttributeState {
kSpellcheckAttributeTrue,
kSpellcheckAttributeFalse,
......
......@@ -46,6 +46,7 @@
#include "third_party/blink/renderer/platform/scheduler/public/post_cancellable_task.h"
#include "third_party/blink/renderer/platform/supplementable.h"
#include "third_party/blink/renderer/platform/timer.h"
#include "third_party/blink/renderer/platform/weborigin/kurl.h"
namespace cc {
class Layer;
......@@ -67,7 +68,6 @@ class HTMLMediaElementControlsList;
class HTMLMediaSource;
class HTMLSourceElement;
class HTMLTrackElement;
class KURL;
class MediaError;
class MediaStreamDescriptor;
class ScriptPromiseResolver;
......
......@@ -31,6 +31,7 @@
#define THIRD_PARTY_BLINK_RENDERER_CORE_HTML_TRACK_VTT_VTT_CUE_H_
#include "third_party/blink/renderer/core/html/track/text_track_cue.h"
#include "third_party/blink/renderer/platform/geometry/float_point.h"
#include "third_party/blink/renderer/platform/heap/handle.h"
#include "third_party/blink/renderer/platform/wtf/allocator/allocator.h"
......
......@@ -37,6 +37,7 @@ namespace blink {
class AffineTransform;
class Document;
class FloatRect;
class SVGAnimatedPropertyBase;
class SubtreeLayoutScope;
class SVGAnimatedString;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment