Commit 264ae6d3 authored by Daniel Murphy's avatar Daniel Murphy Committed by Commit Bot

Fixing PolicyAppPersistsUninstalledOnSync flakiness

The 'dummy' app installed to flush the sync system was installed in the
wrong direction, so changes from profile 1 might not have made it to
profile 0. This change fixes that.

R=loyso@chromium.org

Bug: 1099595
Change-Id: I28b8816e20ac2020d9329342a10936ba09309830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285296
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786497}
parent a7f7ed0c
...@@ -362,9 +362,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, NotSyncedThenSynced) { ...@@ -362,9 +362,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, NotSyncedThenSynced) {
GetRegistrar(GetProfile(1)).GetAppUserDisplayMode(app_id)); GetRegistrar(GetProfile(1)).GetAppUserDisplayMode(app_id));
} }
// TODO(crbug.com/1099595): Fix flakiness on all platforms.
IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest,
DISABLED_PolicyAppPersistsUninstalledOnSync) { PolicyAppPersistsUninstalledOnSync) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameWebAppIds()); ASSERT_TRUE(AllProfilesHaveSameWebAppIds());
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
...@@ -379,8 +378,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, ...@@ -379,8 +378,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest,
// Install a 'dummy' app & wait for installation to ensure sync has processed // Install a 'dummy' app & wait for installation to ensure sync has processed
// the initial apps. // the initial apps.
InstallDummyAppAndWaitForSync(GURL("http://www.dummy.org/"), GetProfile(0), InstallDummyAppAndWaitForSync(GURL("http://www.dummy.org/"), GetProfile(1),
GetProfile(1)); GetProfile(0));
// The app is in both profiles. // The app is in both profiles.
EXPECT_TRUE(AllProfilesHaveSameWebAppIds()); EXPECT_TRUE(AllProfilesHaveSameWebAppIds());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment