Commit 265662cf authored by Takashi Toyoshima's avatar Takashi Toyoshima Committed by Commit Bot

FileURLDirectoryLoader should stop listing on connection errors

If FileURLDirectoryLoader has a net::DirectoryLister instance running,
it continues to call MaybeTransferPendingData() until the listing
finishes. If a connection error happens on the mojo interface, it
results in resetting |data_producer_|, and it causes a null pointer
dereference.

This issue was introduced after the last branch-cut. So only m78 is
affected.

Bug: 990579
Change-Id: I58f73d59022f89c82409e5fc10a6cb2a419b94d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735241Reviewed-by: default avatarChris Mumford <cmumford@google.com>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684288}
parent a0bc4439
...@@ -226,6 +226,7 @@ class FileURLDirectoryLoader ...@@ -226,6 +226,7 @@ class FileURLDirectoryLoader
} }
void OnConnectionError() { void OnConnectionError() {
lister_.reset();
data_producer_.reset(); data_producer_.reset();
binding_.Close(); binding_.Close();
client_.reset(); client_.reset();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment