Add help link for ChromeOS tablet gesture education

Bug: 1056451
Change-Id: I23fb1ad19251bae8e1917b6089b3cb75385e74c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097031
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749576}

ash/public/cpp/system_tray_client.h

@@ -67,6 +67,9 @@ class ASH_PUBLIC_EXPORT SystemTrayClient {
   // Shows the settings related to accessibility.
   virtual void ShowAccessibilitySettings() = 0;
 
+  // Shows gesture education help.
+  virtual void ShowGestureEducationHelp() = 0;
+
   // Shows the help center article for the stylus tool palette.
   virtual void ShowPaletteHelp() = 0;
 

ash/public/cpp/test/test_system_tray_client.cc

@@ -46,6 +46,8 @@ void TestSystemTrayClient::ShowAccessibilityHelp() {}
 
 void TestSystemTrayClient::ShowAccessibilitySettings() {}
 
+void TestSystemTrayClient::ShowGestureEducationHelp() {}
+
 void TestSystemTrayClient::ShowPaletteHelp() {}
 
 void TestSystemTrayClient::ShowPaletteSettings() {}

ash/public/cpp/test/test_system_tray_client.h

@@ -35,6 +35,7 @@ class ASH_PUBLIC_EXPORT TestSystemTrayClient : public SystemTrayClient {
   void ShowHelp() override;
   void ShowAccessibilityHelp() override;
   void ShowAccessibilitySettings() override;
+  void ShowGestureEducationHelp() override;
   void ShowPaletteHelp() override;
   void ShowPaletteSettings() override;
   void ShowPublicAccountInfo() override;

ash/system/gesture_education/gesture_education_notification_controller.cc

@@ -81,7 +81,7 @@ void GestureEducationNotificationController::
 }
 
 void GestureEducationNotificationController::HandleNotificationClick() {
-  Shell::Get()->system_tray_model()->client()->ShowHelp();
+  Shell::Get()->system_tray_model()->client()->ShowGestureEducationHelp();
 }
 
 base::string16 GestureEducationNotificationController::GetNotificationMessage()

chrome/browser/ui/ash/system_tray_client.cc

@@ -274,6 +274,13 @@ void SystemTrayClient::ShowAccessibilitySettings() {
   ShowSettingsSubPageForActiveUser(chrome::kAccessibilitySubPage);
 }
 
+void SystemTrayClient::ShowGestureEducationHelp() {
+  chrome::ScopedTabbedBrowserDisplayer displayer(
+      ProfileManager::GetActiveUserProfile());
+  ShowSingletonTab(displayer.browser(),
+                   GURL(chrome::kChromeOSGestureEducationHelpURL));
+}
+
 void SystemTrayClient::ShowPaletteHelp() {
   chrome::ScopedTabbedBrowserDisplayer displayer(
       ProfileManager::GetActiveUserProfile());

chrome/browser/ui/ash/system_tray_client.h

@@ -66,6 +66,7 @@ class SystemTrayClient : public ash::SystemTrayClient,
   void ShowHelp() override;
   void ShowAccessibilityHelp() override;
   void ShowAccessibilitySettings() override;
+  void ShowGestureEducationHelp() override;
   void ShowPaletteHelp() override;
   void ShowPaletteSettings() override;
   void ShowPublicAccountInfo() override;

chrome/common/url_constants.cc

@@ -319,6 +319,9 @@ const char kChromeOSAssetPath[] = "/usr/share/chromeos-assets/";
 const char kChromeOSCreditsPath[] =
     "/opt/google/chrome/resources/about_os_credits.html";
 
+const char kChromeOSGestureEducationHelpURL[] =
+    "https://support.google.com/chromebook?p=tablet_mode_gestures";
+
 const char kChromePaletteHelpURL[] =
     "https://support.google.com/chromebook?p=stylus_help";
 

chrome/common/url_constants.h

@@ -267,6 +267,9 @@ extern const char kChromeOSAssetPath[];
 
 extern const char kChromeOSCreditsPath[];
 
+// Chrome OS tablet gestures education help link for Chrome.
+extern const char kChromeOSGestureEducationHelpURL[];
+
 // Palette help link for Chrome.
 extern const char kChromePaletteHelpURL[];