Commit 2678850f authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Properly sort the list of sources for browser_tests.

Move the comment, which adds a break to the sources list, and its
associated files into a separate section. As is, the break in the
sources list often confuses people, and that leads them to add files to
the wrong part of the sources list.

Change-Id: I1c969cec45ee678fc2d0c90ab76809d44d98e9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219605Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773375}
parent 03ce13ce
...@@ -1139,32 +1139,6 @@ if (!is_android) { ...@@ -1139,32 +1139,6 @@ if (!is_android) {
"../browser/site_isolation/chrome_site_per_process_test.h", "../browser/site_isolation/chrome_site_per_process_test.h",
"../browser/site_isolation/origin_isolation_browsertest.cc", "../browser/site_isolation/origin_isolation_browsertest.cc",
"../browser/site_isolation/site_details_browsertest.cc", "../browser/site_isolation/site_details_browsertest.cc",
"../browser/ssl/known_interception_disclosure_ui_browsertest.cc",
"../browser/storage_access_api/api_browsertest.cc",
"../browser/ui/blocked_content/popup_opener_tab_helper_browsertest.cc",
"../browser/ui/blocked_content/popup_tracker_browsertest.cc",
"../browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc",
"../browser/ui/blocked_content/tab_under_blocker_browsertest.cc",
"../browser/ui/managed_ui_browsertest.cc",
"../browser/ui/manifest_web_app_browsertest.cc",
"../browser/ui/passwords/google_password_manager_navigation_throttle_browsertest.cc",
"../browser/ui/tabs/pinned_tab_service_browsertest.cc",
"../browser/ui/thumbnails/thumbnail_tab_helper_browsertest.cc",
"../browser/ui/views/accessibility/accessibility_focus_highlight_browsertest.cc",
"../browser/ui/views/eye_dropper/eye_dropper_browsertest.cc",
"../browser/ui/views/sharing/click_to_call_browsertest.cc",
"../browser/ui/views/sharing/remote_copy_browsertest.cc",
"../browser/ui/views/sharing/shared_clipboard_browsertest.cc",
"../browser/ui/views/sharing/sharing_browsertest.cc",
"../browser/ui/views/sharing/sharing_browsertest.h",
"../browser/ui/views/tabs/tab_strip_browsertest.cc",
"../browser/wake_lock/wake_lock_browsertest.cc",
# If this list is used on Android in the future, these browser / speech/*
# files will probably not be applicable.
"../browser/speech/extension_api/tts_extension_apitest.cc",
"../browser/speech/speech_recognition_browsertest.cc",
"../browser/speech/speech_recognizer_browsertest.cc",
"../browser/spellchecker/spellcheck_service_browsertest.cc", "../browser/spellchecker/spellcheck_service_browsertest.cc",
"../browser/ssl/certificate_reporting_test_utils.cc", "../browser/ssl/certificate_reporting_test_utils.cc",
"../browser/ssl/certificate_reporting_test_utils.h", "../browser/ssl/certificate_reporting_test_utils.h",
...@@ -1172,6 +1146,7 @@ if (!is_android) { ...@@ -1172,6 +1146,7 @@ if (!is_android) {
"../browser/ssl/connection_help_tab_helper_browsertest.cc", "../browser/ssl/connection_help_tab_helper_browsertest.cc",
"../browser/ssl/crlset_browsertest.cc", "../browser/ssl/crlset_browsertest.cc",
"../browser/ssl/known_interception_disclosure_infobar_browsertest.cc", "../browser/ssl/known_interception_disclosure_infobar_browsertest.cc",
"../browser/ssl/known_interception_disclosure_ui_browsertest.cc",
"../browser/ssl/security_state_tab_helper_browsertest.cc", "../browser/ssl/security_state_tab_helper_browsertest.cc",
"../browser/ssl/ssl_browsertest.cc", "../browser/ssl/ssl_browsertest.cc",
"../browser/ssl/ssl_client_certificate_selector_test.cc", "../browser/ssl/ssl_client_certificate_selector_test.cc",
...@@ -1179,6 +1154,7 @@ if (!is_android) { ...@@ -1179,6 +1154,7 @@ if (!is_android) {
"../browser/ssl/stateful_ssl_host_state_delegate_test.cc", "../browser/ssl/stateful_ssl_host_state_delegate_test.cc",
"../browser/ssl/typed_navigation_timing_throttle_browsertest.cc", "../browser/ssl/typed_navigation_timing_throttle_browsertest.cc",
"../browser/storage/durable_storage_browsertest.cc", "../browser/storage/durable_storage_browsertest.cc",
"../browser/storage_access_api/api_browsertest.cc",
"../browser/subresource_filter/ad_tagging_browsertest.cc", "../browser/subresource_filter/ad_tagging_browsertest.cc",
"../browser/subresource_filter/ruleset_browsertest.cc", "../browser/subresource_filter/ruleset_browsertest.cc",
"../browser/subresource_filter/subresource_filter_browser_test_harness.cc", "../browser/subresource_filter/subresource_filter_browser_test_harness.cc",
...@@ -1219,6 +1195,10 @@ if (!is_android) { ...@@ -1219,6 +1195,10 @@ if (!is_android) {
"../browser/ui/autofill/payments/card_unmask_prompt_view_tester.h", "../browser/ui/autofill/payments/card_unmask_prompt_view_tester.h",
"../browser/ui/autofill/payments/save_card_bubble_controller_impl_browsertest.cc", "../browser/ui/autofill/payments/save_card_bubble_controller_impl_browsertest.cc",
"../browser/ui/autofill/payments/save_upi_bubble_controller_impl_browsertest.cc", "../browser/ui/autofill/payments/save_upi_bubble_controller_impl_browsertest.cc",
"../browser/ui/blocked_content/popup_opener_tab_helper_browsertest.cc",
"../browser/ui/blocked_content/popup_tracker_browsertest.cc",
"../browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc",
"../browser/ui/blocked_content/tab_under_blocker_browsertest.cc",
"../browser/ui/bookmarks/bookmark_browsertest.cc", "../browser/ui/bookmarks/bookmark_browsertest.cc",
"../browser/ui/browser_browsertest.cc", "../browser/ui/browser_browsertest.cc",
"../browser/ui/browser_command_controller_browsertest.cc", "../browser/ui/browser_command_controller_browsertest.cc",
...@@ -1247,8 +1227,11 @@ if (!is_android) { ...@@ -1247,8 +1227,11 @@ if (!is_android) {
"../browser/ui/hats/hats_survey_status_checker_browsertest.cc", "../browser/ui/hats/hats_survey_status_checker_browsertest.cc",
"../browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc", "../browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc",
"../browser/ui/login/login_handler_browsertest.cc", "../browser/ui/login/login_handler_browsertest.cc",
"../browser/ui/managed_ui_browsertest.cc",
"../browser/ui/manifest_web_app_browsertest.cc",
"../browser/ui/native_window_tracker_browsertest.cc", "../browser/ui/native_window_tracker_browsertest.cc",
"../browser/ui/omnibox/alternate_nav_infobar_delegate_browsertest.cc", "../browser/ui/omnibox/alternate_nav_infobar_delegate_browsertest.cc",
"../browser/ui/passwords/google_password_manager_navigation_throttle_browsertest.cc",
"../browser/ui/passwords/manage_passwords_test.cc", "../browser/ui/passwords/manage_passwords_test.cc",
"../browser/ui/passwords/password_generation_popup_view_browsertest.cc", "../browser/ui/passwords/password_generation_popup_view_browsertest.cc",
"../browser/ui/passwords/password_generation_popup_view_tester.h", "../browser/ui/passwords/password_generation_popup_view_tester.h",
...@@ -1284,6 +1267,7 @@ if (!is_android) { ...@@ -1284,6 +1267,7 @@ if (!is_android) {
"../browser/ui/sync/profile_signin_confirmation_helper_browsertest.cc", "../browser/ui/sync/profile_signin_confirmation_helper_browsertest.cc",
"../browser/ui/tab_modal_confirm_dialog_browsertest.cc", "../browser/ui/tab_modal_confirm_dialog_browsertest.cc",
"../browser/ui/tab_modal_confirm_dialog_browsertest.h", "../browser/ui/tab_modal_confirm_dialog_browsertest.h",
"../browser/ui/tabs/pinned_tab_service_browsertest.cc",
"../browser/ui/test/browser_ui_browsertest.cc", "../browser/ui/test/browser_ui_browsertest.cc",
"../browser/ui/test/test_browser_dialog.cc", "../browser/ui/test/test_browser_dialog.cc",
"../browser/ui/test/test_browser_dialog.h", "../browser/ui/test/test_browser_dialog.h",
...@@ -1293,9 +1277,11 @@ if (!is_android) { ...@@ -1293,9 +1277,11 @@ if (!is_android) {
"../browser/ui/test/test_browser_ui.h", "../browser/ui/test/test_browser_ui.h",
"../browser/ui/test/test_infobar.cc", "../browser/ui/test/test_infobar.cc",
"../browser/ui/test/test_infobar.h", "../browser/ui/test/test_infobar.h",
"../browser/ui/thumbnails/thumbnail_tab_helper_browsertest.cc",
"../browser/ui/toolbar/browser_actions_bar_browsertest.cc", "../browser/ui/toolbar/browser_actions_bar_browsertest.cc",
"../browser/ui/toolbar/browser_actions_bar_browsertest.h", "../browser/ui/toolbar/browser_actions_bar_browsertest.h",
"../browser/ui/update_chrome_dialog_browsertest.cc", "../browser/ui/update_chrome_dialog_browsertest.cc",
"../browser/ui/views/accessibility/accessibility_focus_highlight_browsertest.cc",
"../browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc", "../browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc",
"../browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc", "../browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc",
"../browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc", "../browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc",
...@@ -1304,9 +1290,16 @@ if (!is_android) { ...@@ -1304,9 +1290,16 @@ if (!is_android) {
"../browser/ui/views/content_test_utils.cc", "../browser/ui/views/content_test_utils.cc",
"../browser/ui/views/content_test_utils.h", "../browser/ui/views/content_test_utils.h",
"../browser/ui/views/device_chooser_browsertest.cc", "../browser/ui/views/device_chooser_browsertest.cc",
"../browser/ui/views/eye_dropper/eye_dropper_browsertest.cc",
"../browser/ui/views/hats/hats_browsertest.cc", "../browser/ui/views/hats/hats_browsertest.cc",
"../browser/ui/views/intent_picker_bubble_view_browsertest.cc", "../browser/ui/views/intent_picker_bubble_view_browsertest.cc",
"../browser/ui/views/reader_mode/reader_mode_icon_view_browsertest.cc", "../browser/ui/views/reader_mode/reader_mode_icon_view_browsertest.cc",
"../browser/ui/views/sharing/click_to_call_browsertest.cc",
"../browser/ui/views/sharing/remote_copy_browsertest.cc",
"../browser/ui/views/sharing/shared_clipboard_browsertest.cc",
"../browser/ui/views/sharing/sharing_browsertest.cc",
"../browser/ui/views/sharing/sharing_browsertest.h",
"../browser/ui/views/tabs/tab_strip_browsertest.cc",
"../browser/ui/views/try_chrome_dialog_win/try_chrome_dialog_browsertest.cc", "../browser/ui/views/try_chrome_dialog_win/try_chrome_dialog_browsertest.cc",
"../browser/ui/views/web_apps/web_app_frame_toolbar_browsertest.cc", "../browser/ui/views/web_apps/web_app_frame_toolbar_browsertest.cc",
"../browser/ui/views/web_apps/web_app_minimal_ui_test.cc", "../browser/ui/views/web_apps/web_app_minimal_ui_test.cc",
...@@ -1364,6 +1357,7 @@ if (!is_android) { ...@@ -1364,6 +1357,7 @@ if (!is_android) {
"../browser/ui/zoom/zoom_controller_browsertest.cc", "../browser/ui/zoom/zoom_controller_browsertest.cc",
"../browser/unload_browsertest.cc", "../browser/unload_browsertest.cc",
"../browser/usb/usb_browsertest.cc", "../browser/usb/usb_browsertest.cc",
"../browser/wake_lock/wake_lock_browsertest.cc",
"../browser/webauthn/authenticator_extension_browsertest.cc", "../browser/webauthn/authenticator_extension_browsertest.cc",
"../common/mac/app_mode_chrome_locator_browsertest.mm", "../common/mac/app_mode_chrome_locator_browsertest.mm",
"../common/mac/mock_launchd.h", "../common/mac/mock_launchd.h",
...@@ -1413,6 +1407,14 @@ if (!is_android) { ...@@ -1413,6 +1407,14 @@ if (!is_android) {
"v8/wasm_trap_handler_browsertest.cc", "v8/wasm_trap_handler_browsertest.cc",
] ]
# If this target is used on Android in the future, these browser/speech/*
# files will probably not be applicable.
sources += [
"../browser/speech/extension_api/tts_extension_apitest.cc",
"../browser/speech/speech_recognition_browsertest.cc",
"../browser/speech/speech_recognizer_browsertest.cc",
]
if (is_win) { if (is_win) {
data += [ "$root_out_dir/chrome_200_percent.pak" ] data += [ "$root_out_dir/chrome_200_percent.pak" ]
deps += [ "//chrome/app:chrome_dll_resources" ] deps += [ "//chrome/app:chrome_dll_resources" ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment