Commit 267c241f authored by Rouslan Solomakhin's avatar Rouslan Solomakhin Committed by Commit Bot

[Web Payment] Secure payment confirmation UI polish.

Before this patch, if WebAuthn returned an error when creating an
assertion, Web Payment called into ShowErrorMessage(), which called into
OnCancel(), which rejected the PaymentRequest.show() promise, but kept
the secure payment confirmation UI open.

This patch makes sure that the dialog is closed in OnCancel().

After this patch, if WebAuthn returns an error, then the secure payment
confirmation UI is closed.

Bug: 1122696
Change-Id: I99fae1d7b0b903338fca8cd03ecf57646dd78699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380550
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarNick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802349}
parent 3c3b4bf7
......@@ -165,6 +165,8 @@ void SecurePaymentConfirmationController::OnDismiss() {
}
void SecurePaymentConfirmationController::OnCancel() {
CloseDialog();
if (!request_)
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment