Commit 268fcfac authored by GauthamBanasandra's avatar GauthamBanasandra Committed by Commit Bot

DevTools: Show scriptResponseTime for ServiceWorker only if present

As per the browser protocol, the field scriptResponseTime is
optional. Hence adding a check to see if it present before
displaying it.

Bug: 767790
Change-Id: I2638328aeec901419e48977ba40a15971da43f8b
Reviewed-on: https://chromium-review.googlesource.com/1180623
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586048}
parent 5affa31b
......@@ -404,8 +404,10 @@ Resources.ServiceWorkersView.Section = class {
errorsLabel.addEventListener('click', () => Common.console.show());
name.appendChild(errorsLabel);
}
this._sourceField.createChild('div', 'report-field-value-subtitle').textContent =
Common.UIString('Received %s', new Date(version.scriptResponseTime * 1000).toLocaleString());
if (version.scriptResponseTime) {
this._sourceField.createChild('div', 'report-field-value-subtitle').textContent =
Common.UIString('Received %s', new Date(version.scriptResponseTime * 1000).toLocaleString());
}
}
/**
......@@ -458,16 +460,20 @@ Resources.ServiceWorkersView.Section = class {
const waitingEntry = this._addVersion(
versionsStack, 'service-worker-waiting-circle', Common.UIString('#%s waiting to activate', waiting.id));
createLink(waitingEntry, Common.UIString('skipWaiting'), this._skipButtonClicked.bind(this));
waitingEntry.createChild('div', 'service-worker-subtitle').textContent =
Common.UIString('Received %s', new Date(waiting.scriptResponseTime * 1000).toLocaleString());
if (waiting.scriptResponseTime) {
waitingEntry.createChild('div', 'service-worker-subtitle').textContent =
Common.UIString('Received %s', new Date(waiting.scriptResponseTime * 1000).toLocaleString());
}
if (!this._targetForVersionId(waiting.id) && (waiting.isRunning() || waiting.isStarting()))
createLink(waitingEntry, Common.UIString('inspect'), this._inspectButtonClicked.bind(this, waiting.id));
}
if (installing) {
const installingEntry = this._addVersion(
versionsStack, 'service-worker-installing-circle', Common.UIString('#%s installing', installing.id));
installingEntry.createChild('div', 'service-worker-subtitle').textContent =
Common.UIString('Received %s', new Date(installing.scriptResponseTime * 1000).toLocaleString());
if (installing.scriptResponseTime) {
installingEntry.createChild('div', 'service-worker-subtitle').textContent =
Common.UIString('Received %s', new Date(installing.scriptResponseTime * 1000).toLocaleString());
}
if (!this._targetForVersionId(installing.id) && (installing.isRunning() || installing.isStarting()))
createLink(installingEntry, Common.UIString('inspect'), this._inspectButtonClicked.bind(this, installing.id));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment