Commit 26b382a2 authored by dbeam@chromium.org's avatar dbeam@chromium.org

Update some stale TODO()s in c/b/ui/autofill.

R=estade@chromium.org
BUG=none
TEST=less TODOs

Review URL: https://codereview.chromium.org/25409002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226434 0039d316-1c4b-4281-b951-d872f2087c98
parent 02cad5dc
......@@ -138,8 +138,6 @@ void AccountChooserModel::ReconstructMenuItems() {
} else if (checked_item_ == kActiveWalletItemId) {
// A selected active Wallet account with an empty account name means
// that the sign-in attempt is in progress.
// TODO(aruslan): http://crbug.com/230932
// A throbber should be shown until the Wallet account name is set.
AddCheckItem(kActiveWalletItemId,
l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_GOOGLE_WALLET));
}
......
......@@ -1612,8 +1612,7 @@ bool AutofillDialogControllerImpl::FieldControlsIcons(
return type == CREDIT_CARD_NUMBER;
}
// TODO(estade): Replace all the error messages here with more helpful and
// translateable ones. TODO(groby): Also add tests.
// TODO(groby): Add more tests.
string16 AutofillDialogControllerImpl::InputValidityMessage(
DialogSection section,
ServerFieldType type,
......@@ -2204,7 +2203,7 @@ void AutofillDialogControllerImpl::OnDidAcceptLegalDocuments() {
void AutofillDialogControllerImpl::OnDidAuthenticateInstrument(bool success) {
DCHECK(is_submitting_ && IsPayingWithWallet());
// TODO(dbeam): use the returned full wallet. b/8332329
// TODO(dbeam): use the returned full wallet. http://crbug.com/224992
if (success) {
GetFullWallet();
} else {
......@@ -3159,7 +3158,7 @@ void AutofillDialogControllerImpl::HandleSaveOrUpdateRequiredActions(
const std::vector<wallet::RequiredAction>& required_actions) {
DCHECK(!required_actions.empty());
// TODO(ahutter): Invesitigate if we need to support more generic actions on
// TODO(ahutter): Investigate if we need to support more generic actions on
// this call such as GAIA_AUTH. See crbug.com/243457.
for (std::vector<wallet::RequiredAction>::const_iterator iter =
required_actions.begin();
......
......@@ -1623,23 +1623,6 @@ TEST_F(AutofillDialogControllerTest, ErrorDuringSubmit) {
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
}
// TODO(dbeam): disallow changing accounts instead and remove this test.
TEST_F(AutofillDialogControllerTest, ChangeAccountDuringSubmit) {
EXPECT_CALL(*controller()->GetTestingWalletClient(),
GetFullWallet(_)).Times(1);
SubmitWithWalletItems(CompleteAndValidWalletItems());
EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
SwitchToWallet();
SwitchToAutofill();
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
}
TEST_F(AutofillDialogControllerTest, ErrorDuringVerifyCvv) {
EXPECT_CALL(*controller()->GetTestingWalletClient(),
GetFullWallet(_)).Times(1);
......@@ -1656,24 +1639,6 @@ TEST_F(AutofillDialogControllerTest, ErrorDuringVerifyCvv) {
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
}
// TODO(dbeam): disallow changing accounts instead and remove this test.
TEST_F(AutofillDialogControllerTest, ChangeAccountDuringVerifyCvv) {
EXPECT_CALL(*controller()->GetTestingWalletClient(),
GetFullWallet(_)).Times(1);
SubmitWithWalletItems(CompleteAndValidWalletItems());
controller()->OnDidGetFullWallet(CreateFullWallet("verify_cvv"));
ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
SwitchToWallet();
SwitchToAutofill();
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
}
// Simulates receiving an INVALID_FORM_FIELD required action while processing a
// |WalletClientDelegate::OnDid{Save,Update}*()| call. This can happen if Online
// Wallet's server validation differs from Chrome's local validation.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment