Skip to content

GitLab

T
tangled
Commit 26c11cbe authored by Shakti Sahu's avatar Shakti Sahu Committed by Chromium LUCI CQ
Browse files
Options

Video Tutorials : Rounded corner for animation in IPH cards 

This CL adds rounded corner for the GIF animations in the IPH cards

Bug: 1117148
Change-Id: I81e8914ffa3fea8398df32a8cc226046a699e0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611998
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840946}
parent 764e135c
Hide whitespace changes
Inline Side-by-side
Showing with 118 additions and 13 deletions
chrome/browser/video_tutorials/BUILD.gn
View file @ 26c11cbe
...@@ -90,6 +90,10 @@ if (is_android) { ...@@ -90,6 +90,10 @@ if (is_android) {
android_resources("java_resources") { android_resources("java_resources") {
create_srcjar = false create_srcjar = false
sources = [ sources = [
"android/java/res/drawable/corner_bottom_end.xml",
"android/java/res/drawable/corner_bottom_start.xml",
"android/java/res/drawable/corner_top_end.xml",
"android/java/res/drawable/corner_top_start.xml",
"android/java/res/layout/video_tutorial_iph_card.xml", "android/java/res/layout/video_tutorial_iph_card.xml",
"android/java/res/layout/video_tutorial_list.xml", "android/java/res/layout/video_tutorial_list.xml",
] ]
......
chrome/browser/video_tutorials/android/java/res/drawable/corner_bottom_end.xml 0 → 100644
View file @ 26c11cbe
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2021 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<vector
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="10dp"
android:height="10dp"
android:viewportWidth="10"
android:viewportHeight="10"
android:autoMirrored="true">
<path
android:fillColor="@android:color/white"
android:pathData="M 10,0 A 10,10 0 0 1 0,10 L 10,10 Z" />
</vector>
chrome/browser/video_tutorials/android/java/res/drawable/corner_bottom_start.xml 0 → 100644
View file @ 26c11cbe
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2021 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<vector
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="10dp"
android:height="10dp"
android:viewportWidth="10"
android:viewportHeight="10"
android:autoMirrored="true">
<path
android:fillColor="@android:color/white"
android:pathData="M 0,0 A 10,10 0 0 0 10,10 L 0,10 Z" />
</vector>
chrome/browser/video_tutorials/android/java/res/drawable/corner_top_end.xml 0 → 100644
View file @ 26c11cbe
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2021 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<vector
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="10dp"
android:height="10dp"
android:viewportWidth="10"
android:viewportHeight="10"
android:autoMirrored="true">
<path
android:fillColor="@android:color/white"
android:pathData="M 0,0 A 10,10 0 0 1 10,10 L 10,0 Z" />
</vector>
chrome/browser/video_tutorials/android/java/res/drawable/corner_top_start.xml 0 → 100644
View file @ 26c11cbe
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2021 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<vector
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="10dp"
android:height="10dp"
android:viewportWidth="10"
android:viewportHeight="10"
android:autoMirrored="true">
<path
android:fillColor="@android:color/white"
android:pathData="M 0,10 A 10,10 0 0 1 10,0 L 0,0 Z" />
</vector>
chrome/browser/video_tutorials/android/java/res/layout/video_tutorial_iph_card.xml
View file @ 26c11cbe
...@@ -14,26 +14,59 @@ ...@@ -14,26 +14,59 @@
android:paddingStart="12dp" android:paddingStart="12dp"
android:paddingBottom="12dp" > android:paddingBottom="12dp" >
<org.chromium.components.browser_ui.widget.async_image.AsyncImageView <RelativeLayout
android:id="@+id/thumbnail" android:id="@+id/thumbnail_wrapper"
android:layout_width="80dp" android:layout_width="80dp"
android:layout_height="58dp" android:layout_height="58dp"
android:layout_gravity="center_vertical" android:layout_gravity="center_vertical"
android:layout_marginTop="12dp" android:layout_marginTop="12dp" >
android:importantForAccessibility="no"
app:unavailableSrc="@color/image_loading_color" <org.chromium.components.browser_ui.widget.async_image.AsyncImageView
app:waitingSrc="@color/image_loading_color" android:id="@+id/thumbnail"
app:roundedfillColor="@color/modern_grey_300" android:layout_width="match_parent"
app:cornerRadiusBottomStart="@dimen/default_rounded_corner_radius" android:layout_height="match_parent"
app:cornerRadiusBottomEnd="@dimen/default_rounded_corner_radius" android:importantForAccessibility="no"
app:cornerRadiusTopStart="@dimen/default_rounded_corner_radius" app:unavailableSrc="@color/image_loading_color"
app:cornerRadiusTopEnd="@dimen/default_rounded_corner_radius" /> app:waitingSrc="@color/image_loading_color"
app:roundedfillColor="@color/modern_grey_300" />
<ImageView
android:layout_width="8dp"
android:layout_height="8dp"
android:layout_alignParentStart="true"
android:importantForAccessibility="no"
app:srcCompat="@drawable/corner_top_start"/>
<ImageView
android:layout_width="8dp"
android:layout_height="8dp"
android:layout_alignParentBottom="true"
android:layout_alignParentStart="true"
android:importantForAccessibility="no"
app:srcCompat="@drawable/corner_bottom_start"/>
<ImageView
android:layout_width="8dp"
android:layout_height="8dp"
android:layout_alignParentEnd="true"
android:importantForAccessibility="no"
app:srcCompat="@drawable/corner_top_end"/>
<ImageView
android:layout_width="8dp"
android:layout_height="8dp"
android:layout_alignParentBottom="true"
android:layout_alignParentEnd="true"
android:importantForAccessibility="no"
app:srcCompat="@drawable/corner_bottom_end"/>
</RelativeLayout>
<TextView <TextView
android:id="@+id/video_length" android:id="@+id/video_length"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignBottom="@id/thumbnail" android:layout_alignBottom="@id/thumbnail_wrapper"
android:layout_marginStart="6dp" android:layout_marginStart="6dp"
android:layout_marginBottom="6dp" android:layout_marginBottom="6dp"
android:paddingStart="4dp" android:paddingStart="4dp"
...@@ -45,7 +78,7 @@ ...@@ -45,7 +78,7 @@
android:id="@+id/title" android:id="@+id/title"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_toEndOf="@id/thumbnail" android:layout_toEndOf="@id/thumbnail_wrapper"
android:layout_toStartOf="@id/close_button" android:layout_toStartOf="@id/close_button"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginStart="12dp" android:layout_marginStart="12dp"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment