Commit 26c62017 authored by finnur@chromium.org's avatar finnur@chromium.org

The test is only failing on Mac, so lets just disabled it for Mac specifically...

The test is only failing on Mac, so lets just disabled it for Mac specifically so as to not lose test coverage on other platforms.

TBR=aa
BUG=26035
TEST=None

Review URL: http://codereview.chromium.org/343019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30356 0039d316-1c4b-4281-b951-d872f2087c98
parent 170acd4d
...@@ -24,6 +24,15 @@ ...@@ -24,6 +24,15 @@
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "libxml/globals.h" #include "libxml/globals.h"
#if defined(OS_MACOSX)
// These tests crash frequently on Mac 10.5 Tests debug. http://crbug.com/26035.
#define MAYBE_TestBlacklistDownloading DISABLED_TestBlacklistDownloading
#define MAYBE_TestBlacklistUpdateCheckRequests DISABLED_TestBlacklistUpdateCheckRequests
#else
#define MAYBE_TestBlacklistDownloading TestBlacklistDownloading
#define MAYBE_TestBlacklistUpdateCheckRequests TestBlacklistUpdateCheckRequests
#endif
static int expected_load_flags = static int expected_load_flags =
net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES; net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
...@@ -588,8 +597,8 @@ TEST(ExtensionUpdaterTest, TestExtensionUpdateCheckRequests) { ...@@ -588,8 +597,8 @@ TEST(ExtensionUpdaterTest, TestExtensionUpdateCheckRequests) {
ExtensionUpdaterTest::TestExtensionUpdateCheckRequests(); ExtensionUpdaterTest::TestExtensionUpdateCheckRequests();
} }
// This test is disabled, see bug 26035 // This test is disabled on Mac, see http://crbug.com/26035.
TEST(ExtensionUpdaterTest, DISABLED_TestBlacklistUpdateCheckRequests) { TEST(ExtensionUpdaterTest, MAYBE_TestBlacklistUpdateCheckRequests) {
ExtensionUpdaterTest::TestBlacklistUpdateCheckRequests(); ExtensionUpdaterTest::TestBlacklistUpdateCheckRequests();
} }
...@@ -605,8 +614,8 @@ TEST(ExtensionUpdaterTest, TestSingleExtensionDownloading) { ...@@ -605,8 +614,8 @@ TEST(ExtensionUpdaterTest, TestSingleExtensionDownloading) {
ExtensionUpdaterTest::TestSingleExtensionDownloading(); ExtensionUpdaterTest::TestSingleExtensionDownloading();
} }
// This test is disabled, see bug 26035 // This test is disabled on Mac, see http://crbug.com/26035.
TEST(ExtensionUpdaterTest, DISABLED_TestBlacklistDownloading) { TEST(ExtensionUpdaterTest, MAYBE_TestBlacklistDownloading) {
ExtensionUpdaterTest::TestBlacklistDownloading(); ExtensionUpdaterTest::TestBlacklistDownloading();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment