Commit 26ee25fd authored by Himanshu Jaju's avatar Himanshu Jaju Committed by Commit Bot

Remove/replace Unido TODOs

- Added bug for ice candidate cache
- Removed shared clipboard TODOs with my name

Change-Id: Ia9ae308c7af05a13bca299fd96310bb82bd2f76e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390901Reviewed-by: default avatarRichard Knoll <knollr@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804032}
parent 6d0cfac5
......@@ -31,9 +31,6 @@ import org.chromium.components.browser_ui.notifications.PendingIntentProvider;
* Provides common functionality for handling sharing notifications.
*/
public final class SharingNotificationUtil {
// TODO(himanshujaju) - We have only two small icons, one for error and one for non error. We
// could avoid passing them around.
/**
* Shows a notification with a configuration common to all sharing notifications.
*
......
......@@ -124,8 +124,6 @@ public class SharedClipboardMessageHandler {
/**
* Return the title of error notification shown based on result of send message to other device.
* TODO(himanshujaju) - All text except PAYLOAD_TOO_LARGE are common across features. Extract
* them out when next feature is added.
*
* @param result The result of sending message to other device.
* @return the title for error notification.
......@@ -160,8 +158,6 @@ public class SharedClipboardMessageHandler {
/**
* Returns the text of the error notification shown based on the result of sending a message to
* another device.
* TODO(himanshujaju) - All text except PAYLOAD_TOO_LARGE are common across features. Extract
* them out when next feature is added.
*
* @param result The result of sending a message to another device.
* @param name The name of the receiver device.
......
......@@ -30,7 +30,7 @@ class IceConfigFetcher : public sharing::mojom::IceConfigFetcher {
IceConfigFetcher(const IceConfigFetcher& other) = delete;
IceConfigFetcher& operator=(const IceConfigFetcher& other) = delete;
// TODO(himanshujaju) - Cache configs fetched from server.
// TODO(crbug.com/1124392) - Cache configs fetched from server.
void GetIceServers(GetIceServersCallback callback) override;
private:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment