Commit 27216761 authored by Mohamed Heikal's avatar Mohamed Heikal Committed by Commit Bot

check_android_configuration actually no longer fails build

android-binary-size trybot has been updated to fail if expectation files
are changed even if they dont break the build. This cl now stops
breaking build.

Bug: 1011227
Change-Id: If563429a800c29c8c4e50735fe1211d9fc7ed4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890727Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711269}
parent 5956f2fe
......@@ -492,8 +492,6 @@ https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/android/java/README
with open(unexpected_manifest_failure_file, 'w') as f:
f.write(msg_header)
f.write(msg)
#TODO(mheikal): remove once trybot recipe handles failure files.
sys.exit(1)
def _CreateKeepPredicate(resource_blacklist_regex,
......
......@@ -152,8 +152,6 @@ https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/android/java/README
with open(failure_file_path, 'w') as f:
f.write(msg_header)
f.write(msg)
#TODO(mheikal): remove once trybot reciepe handles the failure files.
sys.exit(1)
def _OptimizeWithR8(options,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment