Commit 27438351 authored by Tibor Dusnoki's avatar Tibor Dusnoki Committed by Commit Bot

fix: Debugger.DoesntExecuteBeyondBreakpoint unittest fail

There is currently a workaround for this test failure for Windows ARM64 https://chromium-review.googlesource.com/c/chromium/src/+/1593360
but it is no longer needed since the fix has landed in llvm https://reviews.llvm.org/D63635

Bug: 925584
Change-Id: I32de8ee38e50265d4875a05f9964cbcb8fc37eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869413
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709468}
parent 3f5ff3e9
......@@ -925,6 +925,7 @@ Thomas Conti <tomc@amazon.com>
Thomas White <im.toms.inbox@gmail.com>
Tiago Vignatti <tiago.vignatti@intel.com>
Tibor Dusnoki <tibor.dusnoki.91@gmail.com>
Tibor Dusnoki <tdusnoki@inf.u-szeged.hu>
Tim Ansell <mithro@mithis.com>
Tim Niederhausen <tim@rnc-ag.de>
Timo Gurr <timo.gurr@gmail.com>
......
......@@ -36,14 +36,8 @@ TEST(Debugger, CrashAtBreakpoint) {
#if defined(OS_WIN)
TEST(Debugger, DoesntExecuteBeyondBreakpoint) {
#if defined(ARCH_CPU_ARM64)
// brk on aarch64 Windows seems to cause an illegal instruction exception
EXPECT_EXIT(CrashWithBreakDebugger(),
::testing::ExitedWithCode(STATUS_ILLEGAL_INSTRUCTION), "");
#else
EXPECT_EXIT(CrashWithBreakDebugger(),
::testing::ExitedWithCode(STATUS_BREAKPOINT), "");
#endif
}
#endif // defined(OS_WIN)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment