apple: Convert GN libs lists to frameworks that use `libs +=`

These were missed by the awk script I ran initially.

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: 1052560
Change-Id: I0cf1677e1054f2ffcb54660820fba61d1c3590a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278363Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786093}

base/BUILD.gn

@@ -1248,6 +1248,7 @@ jumbo_component("base") {
   data = []
   data_deps = []
   libs = []
+  frameworks = []
 
   configs += [
     ":base_flags",
@@ -1864,14 +1865,16 @@ jumbo_component("base") {
     ]
 
     libs += [
+      "bsm",
+      "pmenergy",
+      "pmsample",
+    ]
+    frameworks += [
       "ApplicationServices.framework",
       "AppKit.framework",
-      "bsm",
       "CoreFoundation.framework",
       "IOKit.framework",
       "OpenDirectory.framework",
-      "pmenergy",
-      "pmsample",
       "Security.framework",
     ]
   }
@@ -2014,7 +2017,7 @@ jumbo_component("base") {
       sources += [ "time/time_exploded_ios.cc" ]
     }
 
-    libs += [ "UIKit.framework" ]
+    frameworks += [ "UIKit.framework" ]
   }
 
   if (dep_libevent) {

chrome/browser/BUILD.gn

@@ -4333,7 +4333,7 @@ static_library("browser") {
       "//third_party/google_toolbox_for_mac",
       "//third_party/mozilla",
     ]
-    libs += [
+    frameworks = [
       "Accelerate.framework",
       "AudioUnit.framework",
       "AVFoundation.framework",

chrome/browser/ui/BUILD.gn

@@ -2895,7 +2895,7 @@ static_library("ui") {
       "//ui/accelerated_widget_mac:accelerated_widget_mac",
     ]
     include_dirs = [ "$target_gen_dir" ]
-    libs += [
+    frameworks = [
       "Carbon.framework",
       "Quartz.framework",
     ]

content/browser/BUILD.gn

@@ -40,6 +40,7 @@ jumbo_source_set("browser") {
   ]
   defines = []
   libs = []
+  frameworks = []
   ldflags = []
 
   deps = [
@@ -2113,7 +2114,7 @@ jumbo_source_set("browser") {
   }
 
   if (is_mac) {
-    libs += [ "AppKit.framework" ]
+    frameworks += [ "AppKit.framework" ]
     sources += [
       "../app_shim_remote_cocoa/web_contents_ns_view_bridge.h",
       "../app_shim_remote_cocoa/web_contents_ns_view_bridge.mm",
@@ -2592,7 +2593,7 @@ jumbo_source_set("browser") {
       "//third_party/mozilla",
       "//ui/accelerated_widget_mac",
     ]
-    libs += [
+    frameworks += [
       "Carbon.framework",
       "QuartzCore.framework",
       "IOSurface.framework",

device/fido/BUILD.gn

@@ -66,8 +66,6 @@ component("fido") {
     "//services/device/public/mojom",
   ]
 
-  libs = []  # Extended for mac.
-
   # Android implementation of FIDO is delegated to GMSCore.
   if (!is_android) {
     sources += [
@@ -213,7 +211,7 @@ component("fido") {
       "mac/util.mm",
     ]
 
-    libs += [
+    frameworks = [
       "Foundation.framework",
       "LocalAuthentication.framework",
       "Security.framework",

gpu/BUILD.gn

@@ -410,7 +410,7 @@ test("gl_tests") {
     deps += [ "//ui/android:ui_java" ]
     sources += [ "command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc" ]
   } else if (is_mac) {
-    libs += [ "IOSurface.framework" ]
+    frameworks = [ "IOSurface.framework" ]
     sources += [ "command_buffer/service/shared_image_backing_factory_iosurface_unittest.cc" ]
   } else if (is_win) {
     deps += [

gpu/ipc/service/BUILD.gn

@@ -107,7 +107,7 @@ jumbo_component("service") {
     ]
     deps += [ "//ui/accelerated_widget_mac" ]
     lib_dirs = [ "$mac_sdk_path/usr/lib" ]
-    libs += [
+    frameworks = [
       "CoreGraphics.framework",
       "IOSurface.framework",
       "OpenGL.framework",

media/audio/BUILD.gn

@@ -171,7 +171,7 @@ source_set("audio") {
       "mac/scoped_audio_unit.cc",
       "mac/scoped_audio_unit.h",
     ]
-    libs += [
+    frameworks = [
       "AudioToolbox.framework",
       "AudioUnit.framework",
       "CoreAudio.framework",

media/cast/BUILD.gn

@@ -168,8 +168,6 @@ jumbo_source_set("sender") {
     "//ui/gfx/geometry",
   ]
 
-  libs = []
-
   # iOS and OS X encoders
   if (is_ios || is_mac) {
     sources += [
@@ -177,7 +175,7 @@ jumbo_source_set("sender") {
       "sender/h264_vt_encoder.h",
     ]
 
-    libs += [
+    frameworks = [
       "AudioToolbox.framework",
       "CoreFoundation.framework",
       "CoreMedia.framework",

media/midi/BUILD.gn

@@ -130,7 +130,7 @@ component("midi") {
   }
 
   if (is_mac) {
-    libs += [
+    frameworks = [
       "CoreAudio.framework",
       "CoreFoundation.framework",
       "CoreMIDI.framework",

remoting/host/BUILD.gn

@@ -412,7 +412,7 @@ static_library("common") {
   }
 
   if (is_mac) {
-    libs += [
+    frameworks = [
       "Accelerate.framework",
       "Carbon.framework",
     ]

ui/base/BUILD.gn

@@ -551,7 +551,7 @@ jumbo_component("base") {
   if (is_mac) {
     deps += [ "//third_party/mozilla" ]
 
-    libs += [
+    frameworks = [
       "Accelerate.framework",
       "AppKit.framework",
       "QuartzCore.framework",

ui/base/clipboard/BUILD.gn

@@ -50,12 +50,12 @@ jumbo_component("clipboard_types") {
 
   deps = [ "//base" ]
 
-  libs = []
+  frameworks = []
   if (is_mac || is_ios) {
-    libs += [ "Foundation.framework" ]
+    frameworks += [ "Foundation.framework" ]
   }
   if (is_mac) {
-    libs += [ "AppKit.framework" ]
+    frameworks += [ "AppKit.framework" ]
   }
 }