Switch the macOS certificate viewer to a Mojo call.
The sheet is currently being drawn on a transparent overlay when using remote Cocoa (e.g. PWA windows), which results in a number of UI issues. This was exacerbated by https://chromium-review.googlesource.com/c/chromium/src/+/2324112. Instead, add a ShowCertificateViewer() Mojo call and move the implementation to NativeWidgetNSWindowBridge. Along the way, simplify the implementation. We can now largely rely on Cocoa's built-in lifetime management for the SFCertificatePanel. Bug: 916815, 1130490 Change-Id: Ia33102417510d7c0fc6fb09cf55d9fa61efdfdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421633Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#809861}
Showing
Please register or sign in to comment