Commit 27a829df authored by Greg Thompson's avatar Greg Thompson Committed by Commit Bot

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG=69475,129235,147579,419468,764415
This CL was uploaded by git cl split.

R=sky@chromium.org

Change-Id: I99053d0c38c27a0ad91b426214bff6365c3b4a5e
Reviewed-on: https://chromium-review.googlesource.com/784934Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521415}
parent b9d9d359
...@@ -295,8 +295,16 @@ class BrowserKeyEventsTest : public InProcessBrowserTest { ...@@ -295,8 +295,16 @@ class BrowserKeyEventsTest : public InProcessBrowserTest {
} }
}; };
// Flaky: http://crbug.com/129235, http://crbug.com/81451. #if defined(OS_MACOSX)
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_NormalKeyEvents) { // http://crbug.com/81451
#define MAYBE_NormalKeyEvents DISABLED_NormalKeyEvents
#elif defined(OS_LINUX)
// http://crbug.com/129235
#define MAYBE_NormalKeyEvents DISABLED_NormalKeyEvents
#else
#define MAYBE_NormalKeyEvents NormalKeyEvents
#endif
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_NormalKeyEvents) {
static const KeyEventTestData kTestNoInput[] = { static const KeyEventTestData kTestNoInput[] = {
// a // a
{ ui::VKEY_A, false, false, false, false, { ui::VKEY_A, false, false, false, false,
...@@ -521,9 +529,16 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_CommandKeyEvents) { ...@@ -521,9 +529,16 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_CommandKeyEvents) {
} }
#endif #endif
// Flaky: http://crbug.com/81451 , http://crbug.com/129235 , #if defined(OS_MACOSX)
// also fails on Windows. // http://crbug.com/81451 for mac
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_AccessKeys) { #define MAYBE_AccessKeys DISABLED_AccessKeys
#elif defined(OS_LINUX)
// http://crbug.com/129235
#define MAYBE_AccessKeys DISABLED_AccessKeys
#else
#define MAYBE_AccessKeys AccessKeys
#endif
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_AccessKeys) {
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
// On Mac, access keys use ctrl+alt modifiers. // On Mac, access keys use ctrl+alt modifiers.
static const KeyEventTestData kTestAccessA = { static const KeyEventTestData kTestAccessA = {
...@@ -658,7 +673,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_AccessKeys) { ...@@ -658,7 +673,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_AccessKeys) {
} }
// Flaky, http://crbug.com/69475. // Flaky, http://crbug.com/69475.
#if defined(OS_LINUX) || defined(OS_WIN) #if defined(OS_LINUX)
#define MAYBE_ReservedAccelerators DISABLED_ReservedAccelerators #define MAYBE_ReservedAccelerators DISABLED_ReservedAccelerators
#else #else
#define MAYBE_ReservedAccelerators ReservedAccelerators #define MAYBE_ReservedAccelerators ReservedAccelerators
...@@ -786,7 +801,12 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, EditorKeyBindings) { ...@@ -786,7 +801,12 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, EditorKeyBindings) {
#endif #endif
// See http://crbug.com/147579 // See http://crbug.com/147579
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_PageUpDownKeys) { #if defined(OS_WIN)
#define MAYBE_PageUpDownKeys PageUpDownKeys
#else
#define MAYBE_PageUpDownKeys DISABLED_PageUpDownKeys
#endif
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_PageUpDownKeys) {
static const KeyEventTestData kTestPageUp = { static const KeyEventTestData kTestPageUp = {
ui::VKEY_PRIOR, false, false, false, false, ui::VKEY_PRIOR, false, false, false, false,
false, false, false, false, 2, false, false, false, false, 2,
......
...@@ -82,10 +82,9 @@ class MouseLeaveTest : public InProcessBrowserTest { ...@@ -82,10 +82,9 @@ class MouseLeaveTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(MouseLeaveTest); DISALLOW_COPY_AND_ASSIGN(MouseLeaveTest);
}; };
#if defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_WIN) #if defined(OS_MACOSX) || defined(OS_LINUX)
// OS_MACOSX: Missing automation provider support: http://crbug.com/45892. // OS_MACOSX: Missing automation provider support: http://crbug.com/45892.
// OS_LINUX: http://crbug.com/133361. // OS_LINUX: http://crbug.com/133361.
// OS_WIN: http://crbug.com/419468
#define MAYBE_TestOnMouseOut DISABLED_TestOnMouseOut #define MAYBE_TestOnMouseOut DISABLED_TestOnMouseOut
#else #else
#define MAYBE_TestOnMouseOut TestOnMouseOut #define MAYBE_TestOnMouseOut TestOnMouseOut
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment