CodeHealth: Change base::Bind to Repeating in chrome/test/chromedriver.

This CL is part of the Code Health Rotation
(https://sites.google.com/corp/google.com/chrome-code-health/) and
changes the few remaining occurrences in chrome/test/chromedriver of
base::Bind, base::Callback, and base::Closure, to base::BindRepeating,
base::RepeatingCallback, and base::RepeatingClosure, respectively, to
match the surrounding code.

Bug: 1007643
Change-Id: I3070f02201bdc338b6b70ab8f3b8b40f5111a6c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622991
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842319}

chrome/test/chromedriver/commands.cc

@@ -87,7 +87,7 @@ void ExecuteCreateSession(SessionThreadMap* session_thread_map,
 namespace {
 
 void OnGetSession(const base::WeakPtr<size_t>& session_remaining_count,
-                  const base::Closure& all_get_session_func,
+                  const base::RepeatingClosure& all_get_session_func,
                   base::ListValue* session_list,
                   const Status& status,
                   std::unique_ptr<base::Value> value,
@@ -144,7 +144,7 @@ void ExecuteGetSessions(const Command& session_capabilities_command,
 namespace {
 
 void OnSessionQuit(const base::WeakPtr<size_t>& quit_remaining_count,
-                   const base::Closure& all_quit_func,
+                   const base::RepeatingClosure& all_quit_func,
                    const Status& status,
                    std::unique_ptr<base::Value> value,
                    const std::string& session_id,
@@ -205,7 +205,7 @@ void ExecuteSessionCommandOnSessionThread(
     std::unique_ptr<base::DictionaryValue> params,
     scoped_refptr<base::SingleThreadTaskRunner> cmd_task_runner,
     const CommandCallback& callback_on_cmd,
-    const base::Closure& terminate_on_cmd) {
+    const base::RepeatingClosure& terminate_on_cmd) {
   Session* session = GetThreadLocalSession();
 
   if (!session) {

chrome/test/chromedriver/element_commands.h

@@ -20,12 +20,12 @@ class Status;
 class Timeout;
 class WebView;
 
-typedef base::Callback<Status(Session* session,
-                              WebView* web_view,
-                              const std::string&,
-                              const base::DictionaryValue&,
-                              std::unique_ptr<base::Value>*)>
-    ElementCommand;
+using ElementCommand =
+    base::RepeatingCallback<Status(Session* session,
+                                   WebView* web_view,
+                                   const std::string&,
+                                   const base::DictionaryValue&,
+                                   std::unique_ptr<base::Value>*)>;
 
 // Execute a command on a specific element.
 Status ExecuteElementCommand(

chrome/test/chromedriver/server/http_handler.cc

@@ -311,12 +311,14 @@ HttpHandler::HttpHandler(
           kGet, "session/:sessionId/element/:id/enabled",
           WrapToCommand("IsElementEnabled",
                         base::BindRepeating(&ExecuteIsElementEnabled))),
-      CommandMapping(kGet, "session/:sessionId/element/:id/computedlabel",
-                     WrapToCommand("GetComputedLabel",
-                                   base::Bind(&ExecuteGetComputedLabel))),
-      CommandMapping(kGet, "session/:sessionId/element/:id/computedrole",
-                     WrapToCommand("GetComputedRole",
-                                   base::Bind(&ExecuteGetComputedRole))),
+      CommandMapping(
+          kGet, "session/:sessionId/element/:id/computedlabel",
+          WrapToCommand("GetComputedLabel",
+                        base::BindRepeating(&ExecuteGetComputedLabel))),
+      CommandMapping(
+          kGet, "session/:sessionId/element/:id/computedrole",
+          WrapToCommand("GetComputedRole",
+                        base::BindRepeating(&ExecuteGetComputedRole))),
       CommandMapping(kPost, "session/:sessionId/element/:id/click",
                      WrapToCommand("ClickElement",
                                    base::BindRepeating(&ExecuteClickElement))),
@@ -1014,16 +1016,17 @@ Command HttpHandler::WrapToCommand(const char* name,
 Command HttpHandler::WrapToCommand(const char* name,
                                    const WindowCommand& window_command,
                                    bool w3c_standard_command) {
-  return WrapToCommand(name, base::Bind(&ExecuteWindowCommand, window_command),
-                       w3c_standard_command);
+  return WrapToCommand(
+      name, base::BindRepeating(&ExecuteWindowCommand, window_command),
+      w3c_standard_command);
 }
 
 Command HttpHandler::WrapToCommand(const char* name,
                                    const ElementCommand& element_command,
                                    bool w3c_standard_command) {
-  return WrapToCommand(name,
-                       base::Bind(&ExecuteElementCommand, element_command),
-                       w3c_standard_command);
+  return WrapToCommand(
+      name, base::BindRepeating(&ExecuteElementCommand, element_command),
+      w3c_standard_command);
 }
 
 void HttpHandler::HandleCommand(

chrome/test/chromedriver/window_commands.h

@@ -22,12 +22,12 @@ class Status;
 class Timeout;
 class WebView;
 
-typedef base::Callback<Status(Session* session,
-                              WebView* web_view,
-                              const base::DictionaryValue&,
-                              std::unique_ptr<base::Value>*,
-                              Timeout*)>
-    WindowCommand;
+using WindowCommand =
+    base::RepeatingCallback<Status(Session* session,
+                                   WebView* web_view,
+                                   const base::DictionaryValue&,
+                                   std::unique_ptr<base::Value>*,
+                                   Timeout*)>;
 
 // Execute a Window Command on the target window.
 Status ExecuteWindowCommand(const WindowCommand& command,