Commit 27aeb845 authored by Andrey Zaytsev's avatar Andrey Zaytsev Committed by Commit Bot

Safety check on Android: fixed callback behavior on destruction

Bug: 1123075, 1070620
Change-Id: Id3e1a4c13532a846332935c70cdc02059881ccb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385335
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: default avatarMartin Šrámek <msramek@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#803098}
parent b6ccba73
......@@ -292,10 +292,12 @@ class SafetyCheckMediator implements PasswordCheck.Observer, SafetyCheckCommonOb
@Override
public void onSafeBrowsingCheckResult(@SafeBrowsingStatus int status) {
mRunnableSafeBrowsing = () -> {
RecordHistogram.recordEnumeratedHistogram("Settings.SafetyCheck.SafeBrowsingResult",
status, SafeBrowsingStatus.MAX_VALUE);
mModel.set(SafetyCheckProperties.SAFE_BROWSING_STATE,
SafetyCheckProperties.safeBrowsingStateFromNative(status));
if (mModel != null) {
RecordHistogram.recordEnumeratedHistogram("Settings.SafetyCheck.SafeBrowsingResult",
status, SafeBrowsingStatus.MAX_VALUE);
mModel.set(SafetyCheckProperties.SAFE_BROWSING_STATE,
SafetyCheckProperties.safeBrowsingStateFromNative(status));
}
};
// Show the checking state for at least 1 second for a smoother UX.
mHandler.postDelayed(mRunnableSafeBrowsing, getModelUpdateDelay());
......@@ -337,13 +339,16 @@ class SafetyCheckMediator implements PasswordCheck.Observer, SafetyCheckCommonOb
// Handle error state.
if (status != PasswordCheckUIStatus.IDLE) {
mRunnablePasswords = () -> {
@SafetyCheckProperties.PasswordsState
int state = SafetyCheckProperties.passwordsStatefromErrorState(status);
RecordHistogram.recordEnumeratedHistogram("Settings.SafetyCheck.PasswordsResult",
SafetyCheckProperties.passwordsStateToNative(state),
PasswordsStatus.MAX_VALUE);
mModel.set(SafetyCheckProperties.PASSWORDS_STATE, state);
updatePasswordElementClickDestination();
if (mModel != null) {
@SafetyCheckProperties.PasswordsState
int state = SafetyCheckProperties.passwordsStatefromErrorState(status);
RecordHistogram.recordEnumeratedHistogram(
"Settings.SafetyCheck.PasswordsResult",
SafetyCheckProperties.passwordsStateToNative(state),
PasswordsStatus.MAX_VALUE);
mModel.set(SafetyCheckProperties.PASSWORDS_STATE, state);
updatePasswordElementClickDestination();
}
};
// Show the checking state for at least 1 second for a smoother UX.
mHandler.postDelayed(mRunnablePasswords, getModelUpdateDelay());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment