Remove Grit's obsolete attribute

Remove obsolete sconsdep attribute
from Grit


Bug: 961834
Change-Id: Idbc1d0b95b3e8fd4a0170ae10df8dd9c6f02eb82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736687Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684305}

tools/grit/grit/node/structure.py

@@ -139,12 +139,6 @@ class StructureNode(base.Node):
              'preprocess': 'false',
              'flattenhtml': 'false',
              'fallback_to_low_resolution': 'default',
-             # TODO(joi) this is a hack - should output all generated files
-             # as SCons dependencies; however, for now there is a bug I can't
-             # find where GRIT doesn't build the matching fileset, therefore
-             # this hack so that only the files you really need are marked as
-             # dependencies.
-             'sconsdep' : 'false',
              'variables': '',
              'compress': 'false',
              'use_base_dir': 'true',

tools/grit/grit_info.py

@@ -37,20 +37,6 @@ def Outputs(filename, defines, ids_file, target_platform=None):
     if output.attrs['lang']:
       lang_folders[output.attrs['lang']] = os.path.dirname(path)
 
-  # Add all generated files, once for each output language.
-  for node in grd:
-    if node.name == 'structure':
-      with node:
-        # TODO(joi) Should remove the "if sconsdep is true" thing as it is a
-        # hack - see grit/node/structure.py
-        if node.HasFileForLanguage() and node.attrs['sconsdep'] == 'true':
-          for lang in lang_folders:
-            path = node.FileForLanguage(lang, lang_folders[lang],
-                                        create_file=False,
-                                        return_if_not_generated=False)
-            if path:
-              target.append(path)
-
   return [t.replace('\\', '/') for t in target]