Commit 27b1d062 authored by evan@chromium.org's avatar evan@chromium.org

Remove rendundant use of product_name in gyp files.

We default to using the target name as the product name;
there's no need to state it twice.

Review URL: http://codereview.chromium.org/7135006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88556 0039d316-1c4b-4281-b951-d872f2087c98
parent 06a45ebb
...@@ -420,18 +420,14 @@ ...@@ -420,18 +420,14 @@
}], }],
['OS != "mac"', { ['OS != "mac"', {
'conditions': [ 'conditions': [
['branding=="Chrome"', { # TODO: add a:
'product_name': 'chrome' # 'product_name': 'chromium'
}, { # else: Branding!="Chrome" # whenever we convert the rest of the infrastructure
# TODO: change to: # (buildbots etc.) to understand the branding gyp define.
# 'product_name': 'chromium' # NOTE: chrome/app/theme/chromium/BRANDING and
# whenever we convert the rest of the infrastructure # chrome/app/theme/google_chrome/BRANDING have the short name
# (buildbots etc.) to use "gyp -Dbranding=Chrome". # "chrome" etc.; should we try to extract from there instead?
# NOTE: chrome/app/theme/chromium/BRANDING and
# chrome/app/theme/google_chrome/BRANDING have the short names,
# etc.; should we try to extract from there instead?
'product_name': 'chrome'
}],
# On Mac, this is done in chrome_dll.gypi. # On Mac, this is done in chrome_dll.gypi.
['internal_pdf', { ['internal_pdf', {
'dependencies': [ 'dependencies': [
......
...@@ -22,7 +22,6 @@ ...@@ -22,7 +22,6 @@
'targets': [ 'targets': [
{ {
'target_name': 'ssl', 'target_name': 'ssl',
'product_name': 'ssl',
'type': 'static_library', 'type': 'static_library',
'sources': [ 'sources': [
'ssl/authcert.c', 'ssl/authcert.c',
......
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
], ],
'conditions': [ 'conditions': [
['OS=="win"', { ['OS=="win"', {
'product_name': 'ppapi_example',
'type': 'shared_library', 'type': 'shared_library',
'msvs_guid': 'EE00E36E-9E8C-4DFB-925E-FBE32CEDB91B', 'msvs_guid': 'EE00E36E-9E8C-4DFB-925E-FBE32CEDB91B',
'sources': [ 'sources': [
...@@ -32,7 +31,6 @@ ...@@ -32,7 +31,6 @@
}, },
}], }],
['os_posix == 1 and OS != "mac"', { ['os_posix == 1 and OS != "mac"', {
'product_name': 'ppapi_example',
'type': 'shared_library', 'type': 'shared_library',
'cflags': ['-fvisibility=hidden'], 'cflags': ['-fvisibility=hidden'],
# -gstabs, used in the official builds, causes an ICE. Simply remove # -gstabs, used in the official builds, causes an ICE. Simply remove
......
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
'targets': [ 'targets': [
{ {
'target_name': 'iccjpeg', 'target_name': 'iccjpeg',
'product_name': 'iccjpeg',
'type': 'static_library', 'type': 'static_library',
'dependencies': [ 'dependencies': [
'<(libjpeg_gyp_path):libjpeg', '<(libjpeg_gyp_path):libjpeg',
......
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
'targets': [ 'targets': [
{ {
'target_name': 'qcms', 'target_name': 'qcms',
'product_name': 'qcms',
'type': 'static_library', 'type': 'static_library',
'sources': [ 'sources': [
'qcms.h', 'qcms.h',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment