Commit 27cd342c authored by piotrs's avatar piotrs Committed by Commit bot

More tests for UrlUtilities#isValidForIntentFallbackNavigation.

I stumbled on isValidForIntentFallbackNavigation and found that having this
more verbose tests would make it easier for me to understand what I can expect
from this method, without having to trace down its implementation.

Not feeling strongly, but I think these are worth adding.

BUG=

Review-Url: https://codereview.chromium.org/2855293002
Cr-Commit-Position: refs/heads/master@{#469567}
parent 8976caef
...@@ -83,6 +83,10 @@ public class UrlUtilitiesTest { ...@@ -83,6 +83,10 @@ public class UrlUtilitiesTest {
UrlUtilities.isValidForIntentFallbackNavigation("http://awesome.example.com/")); UrlUtilities.isValidForIntentFallbackNavigation("http://awesome.example.com/"));
Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("inline:skates.co.uk")); Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("inline:skates.co.uk"));
Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("javascript:alert(1)")); Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("javascript:alert(1)"));
Assert.assertFalse(
UrlUtilities.isValidForIntentFallbackNavigation("file://hostname/path/to/file"));
Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("data:data"));
Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("about:awesome"));
Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation("")); Assert.assertFalse(UrlUtilities.isValidForIntentFallbackNavigation(""));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment