Commit 27de0cdd authored by Sam Maier's avatar Sam Maier Committed by Commit Bot

Android: moving download onclick execution to thread pool

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
since this use doesn't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: Iad83ebccb137eec01ff32bc1f78d72047859efc8
Reviewed-on: https://chromium-review.googlesource.com/1158789Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579915}
parent c99b8240
...@@ -95,7 +95,8 @@ public class DuplicateDownloadInfoBar extends ConfirmInfoBar { ...@@ -95,7 +95,8 @@ public class DuplicateDownloadInfoBar extends ConfirmInfoBar {
ContextUtils.getApplicationContext()); ContextUtils.getApplicationContext());
} }
} }
}.execute(); }
.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
} }
}); });
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment