Commit 27f8a051 authored by Dominic Battre's avatar Dominic Battre Committed by Chromium LUCI CQ

Deflake some credit card tests

Some credit card tests may start executing before the
PersonalDataManager they depend on is fully loaded. This CL introduces
waiting for that to be completed.

Bug: 1163102,1162474
Change-Id: I394b690fe0e98925b0c6f1e8deb8be9b5388944a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628947
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Dominic Battré <battre@chromium.org>
Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Reviewed-by: default avatarMatthias Körber <koerber@google.com>
Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844826}
parent 1123103e
...@@ -30,6 +30,10 @@ class CreditCardAccessManagerBrowserTest : public InProcessBrowserTest { ...@@ -30,6 +30,10 @@ class CreditCardAccessManagerBrowserTest : public InProcessBrowserTest {
embedded_test_server()->ServeFilesFromSourceDirectory( embedded_test_server()->ServeFilesFromSourceDirectory(
"components/test/data/autofill"); "components/test/data/autofill");
embedded_test_server()->StartAcceptingConnections(); embedded_test_server()->StartAcceptingConnections();
// Wait for Personal Data Manager to be fully loaded to prevent that
// spurious notifications deceive the tests.
WaitForPersonalDataManagerToBeLoaded(browser()->profile());
} }
CreditCardAccessManager* GetCreditCardAccessManager() { CreditCardAccessManager* GetCreditCardAccessManager() {
......
...@@ -214,6 +214,10 @@ class LocalCardMigrationBrowserTest ...@@ -214,6 +214,10 @@ class LocalCardMigrationBrowserTest
personal_data_ = personal_data_ =
PersonalDataManagerFactory::GetForProfile(browser()->profile()); PersonalDataManagerFactory::GetForProfile(browser()->profile());
// Wait for Personal Data Manager to be fully loaded to prevent that
// spurious notifications deceive the tests.
WaitForPersonalDataManagerToBeLoaded(browser()->profile());
// Set up the fake geolocation data. // Set up the fake geolocation data.
geolocation_overrider_ = geolocation_overrider_ =
std::make_unique<device::ScopedGeolocationOverrider>( std::make_unique<device::ScopedGeolocationOverrider>(
......
...@@ -212,6 +212,10 @@ class SaveCardBubbleViewsFullFormBrowserTest ...@@ -212,6 +212,10 @@ class SaveCardBubbleViewsFullFormBrowserTest
->GetPaymentsClient() ->GetPaymentsClient()
->set_url_loader_factory_for_testing(test_shared_loader_factory_); ->set_url_loader_factory_for_testing(test_shared_loader_factory_);
// Wait for Personal Data Manager to be fully loaded to prevent that
// spurious notifications deceive the tests.
WaitForPersonalDataManagerToBeLoaded(browser()->profile());
// Set up this class as the ObserverForTest implementation. // Set up this class as the ObserverForTest implementation.
credit_card_save_manager_ = ContentAutofillDriver::GetForRenderFrameHost( credit_card_save_manager_ = ContentAutofillDriver::GetForRenderFrameHost(
GetActiveWebContents()->GetMainFrame()) GetActiveWebContents()->GetMainFrame())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment