Commit 28067db8 authored by Yue Zhang's avatar Yue Zhang Committed by Commit Bot

Re-enable potential victim tests of orientation reset issue

Some of the tests disabled by https://crrev.com/c/1951894 are due to
unexpected device orientation change possibly caused by previously
runned tests changing orientation but never resetting back. Now that
we have reset orientation in http://crrev.com/c/1972942, re-enable
these tests to see if the problem is resolved.

Bug: 1033970, 1030561, 1030562
Change-Id: I41c7bfba8d3a8962423d571196190475e821bc20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976014
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726401}
parent fc391b3d
...@@ -31,7 +31,6 @@ import org.chromium.base.test.params.ParameterizedRunner; ...@@ -31,7 +31,6 @@ import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf; import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest; import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
...@@ -451,7 +450,6 @@ public class BookmarkTest { ...@@ -451,7 +450,6 @@ public class BookmarkTest {
@MediumTest @MediumTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "Flaky. crbug.com/1030561")
public void testBookmarkFolderIcon(boolean nightModeEnabled) throws Exception { public void testBookmarkFolderIcon(boolean nightModeEnabled) throws Exception {
BookmarkPromoHeader.forcePromoStateForTests(BookmarkPromoHeader.PromoState.PROMO_NONE); BookmarkPromoHeader.forcePromoStateForTests(BookmarkPromoHeader.PromoState.PROMO_NONE);
BookmarkId testId = addFolder(TEST_FOLDER_TITLE); BookmarkId testId = addFolder(TEST_FOLDER_TITLE);
......
...@@ -35,7 +35,6 @@ import org.chromium.base.task.PostTask; ...@@ -35,7 +35,6 @@ import org.chromium.base.task.PostTask;
import org.chromium.base.test.params.ParameterAnnotations; import org.chromium.base.test.params.ParameterAnnotations;
import org.chromium.base.test.params.ParameterizedRunner; import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils; import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.R; import org.chromium.chrome.R;
...@@ -181,7 +180,6 @@ public class ArticleSnippetsTest { ...@@ -181,7 +180,6 @@ public class ArticleSnippetsTest {
@MediumTest @MediumTest
@Feature({"ArticleSnippets", "RenderTest"}) @Feature({"ArticleSnippets", "RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "Flaky. crbug.com/1030562")
public void testSnippetAppearance(boolean nightModeEnabled) throws IOException { public void testSnippetAppearance(boolean nightModeEnabled) throws IOException {
SuggestionsCategoryInfo fullCategoryInfo = new SuggestionsCategoryInfo(FULL_CATEGORY, SuggestionsCategoryInfo fullCategoryInfo = new SuggestionsCategoryInfo(FULL_CATEGORY,
"Section Title", ContentSuggestionsCardLayout.FULL_CARD, "Section Title", ContentSuggestionsCardLayout.FULL_CARD,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment