Commit 28112c00 authored by Mirko Bonadei's avatar Mirko Bonadei Committed by Commit Bot

Disable presubmit for invalid defined check in ABSL code.

ABSL is trying to be -Wundef clean and sending a patch for these
macros seems overkill. They are used inside a __APPLE__ block with
this pattern:

#if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
#endif

Bug: None
Change-Id: I863d099dcc3a2588388afab24a61be89884b392b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612913Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660995}
parent 63f4582f
...@@ -3636,8 +3636,9 @@ def _CheckForInvalidIfDefinedMacrosInFile(input_api, f): ...@@ -3636,8 +3636,9 @@ def _CheckForInvalidIfDefinedMacrosInFile(input_api, f):
def _CheckForInvalidIfDefinedMacros(input_api, output_api): def _CheckForInvalidIfDefinedMacros(input_api, output_api):
"""Check all affected files for invalid "if defined" macros.""" """Check all affected files for invalid "if defined" macros."""
bad_macros = [] bad_macros = []
skipped_paths = ['third_party/sqlite/', 'third_party/abseil-cpp/']
for f in input_api.AffectedFiles(): for f in input_api.AffectedFiles():
if f.LocalPath().startswith('third_party/sqlite/'): if any([f.LocalPath().startswith(path) for path in skipped_paths]):
continue continue
if f.LocalPath().endswith(('.h', '.c', '.cc', '.m', '.mm')): if f.LocalPath().endswith(('.h', '.c', '.cc', '.m', '.mm')):
bad_macros.extend(_CheckForInvalidIfDefinedMacrosInFile(input_api, f)) bad_macros.extend(_CheckForInvalidIfDefinedMacrosInFile(input_api, f))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment