Mark some blink testing targets testonly

This forbids production code depending on these targets, and enables
these targets to depend on other testonly targets in the future.

The only dependency prevented core:testing from being testonly was
from BlinkLeakDetector.
Add Page::SetInternalSettingsPrepareForLeakDetectionCallback()
to reverse the dependency.

Change-Id: I64cba73f0c4d1383a192e468220f3d55e926a8f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864720
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708516}

third_party/blink/renderer/controller/BUILD.gn

@@ -18,7 +18,6 @@ jumbo_component("controller") {
   deps = [
     "//skia",
     "//third_party/blink/renderer/core",
-    "//third_party/blink/renderer/core:testing",
     "//third_party/blink/renderer/modules",
     "//third_party/blink/renderer/platform",
     "//v8",

third_party/blink/renderer/controller/blink_leak_detector.cc

@@ -67,10 +67,7 @@ void BlinkLeakDetector::PerformLeakDetection(
   for (auto resource_fetcher : ResourceFetcher::MainThreadFetchers())
     resource_fetcher->PrepareForLeakDetection();
 
-  // Internal settings are ScriptWrappable and thus may retain documents
-  // depending on whether the garbage collector(s) are able to find the settings
-  // object through the Page supplement.
-  InternalSettings::PrepareForLeakDetection();
+  Page::PrepareForLeakDetection();
 
   // Task queue may contain delayed object destruction tasks.
   // This method is called from navigation hook inside FrameLoader,

third_party/blink/renderer/core/BUILD.gn

@@ -241,6 +241,8 @@ component("core") {
 }
 
 jumbo_source_set("testing") {
+  testonly = true
+
   configs += [
     ":blink_core_pch",
     "//third_party/blink/renderer:config",

third_party/blink/renderer/core/page/page.cc

@@ -1019,6 +1019,21 @@ void Page::ClearMediaFeatureOverrides() {
   SettingsChanged(SettingsDelegate::kColorSchemeChange);
 }
 
+static void (*g_internal_settings_prepare_for_leak_detection_callback)() =
+    nullptr;
+
+// static
+void Page::SetInternalSettingsPrepareForLeakDetectionCallback(
+    void (*callback)()) {
+  g_internal_settings_prepare_for_leak_detection_callback = callback;
+}
+
+// static
+void Page::PrepareForLeakDetection() {
+  if (!g_internal_settings_prepare_for_leak_detection_callback)
+    g_internal_settings_prepare_for_leak_detection_callback();
+}
+
 Page::PageClients::PageClients() : chrome_client(nullptr) {}
 
 Page::PageClients::~PageClients() = default;

third_party/blink/renderer/core/page/page.h

@@ -341,6 +341,12 @@ class CORE_EXPORT Page final : public GarbageCollected<Page>,
     return history_navigation_virtual_time_pauser_;
   }
 
+  // See InternalSettings::PrepareForLeakDetection(). The callback is to avoid
+  // dependency from production code to test-only code.
+  static void SetInternalSettingsPrepareForLeakDetectionCallback(
+      void (*callback)());
+  static void PrepareForLeakDetection();
+
  private:
   friend class ScopedPagePauser;
 

third_party/blink/renderer/core/testing/internal_settings.cc

@@ -122,7 +122,10 @@ InternalSettings::~InternalSettings() = default;
 InternalSettings::InternalSettings(Page& page)
     : InternalSettingsGenerated(&page),
       Supplement<Page>(page),
-      backup_(&page.GetSettings()) {}
+      backup_(&page.GetSettings()) {
+  Page::SetInternalSettingsPrepareForLeakDetectionCallback(
+      &PrepareForLeakDetection);
+}
 
 void InternalSettings::ResetToConsistentState() {
   backup_.RestoreTo(GetSettings());
@@ -557,8 +560,10 @@ void InternalSettings::setUniversalAccessFromFileURLs(
 }
 
 void InternalSettings::PrepareForLeakDetection() {
-  // Prepares for leak detection by removing all InternalSetting objects from
-  // Pages.
+  // Internal settings are ScriptWrappable and thus may retain documents
+  // depending on whether the garbage collector(s) are able to find the settings
+  // object through the Page supplement. Prepares for leak detection by
+  // removing all InternalSetting objects from Pages.
   for (Page* page : Page::OrdinaryPages()) {
     page->RemoveSupplement<InternalSettings>();
   }

third_party/blink/renderer/core/testing/internal_settings.h

@@ -51,8 +51,6 @@ class InternalSettings final : public InternalSettingsGenerated,
  public:
   static const char kSupplementName[];
 
-  static void PrepareForLeakDetection();
-
   class Backup {
     DISALLOW_NEW();
 
@@ -147,6 +145,7 @@ class InternalSettings final : public InternalSettingsGenerated,
   void SetPreloadLogging(bool, ExceptionState&);
 
  private:
+  static void PrepareForLeakDetection();
   Settings* GetSettings() const;
   Page* GetPage() const { return GetSupplementable(); }
 

third_party/blink/renderer/modules/exported/BUILD.gn

@@ -23,6 +23,8 @@ blink_modules_sources("exported") {
 }
 
 static_library("test_support") {
+  testonly = true
+
   deps = [
     "//skia",
     "//third_party/blink/renderer/core:testing",