Fix reorder-init-list warning.

Bug: 999871
Change-Id: I7150887216de2fcb0245def70c60ca00bbfe9192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869219
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#707855}

build/config/compiler/BUILD.gn

@@ -1524,9 +1524,6 @@ config("default_warnings") {
           # also fires in only 4 files.
           "-Wno-c99-designator",
 
-          # This is a side effect of -Wc99-designator; easier to clean up.
-          "-Wno-reorder-init-list",
-
           # TODO(https://crbug.com/999886): Clean up, enable.
           "-Wno-final-dtor-non-final-class",
 

chrome/browser/memory/memory_pressure_monitor_win.cc

@@ -105,9 +105,9 @@ FreeMemoryObservationWindow::Config GetFreeMemoryWindowConfig() {
   }
 
   return {
+      .sample_ratio_to_be_positive = kFreeMemorySampleRatioToBePositive.Get(),
       .low_memory_early_limit_mb = low_memory_early_limit_mb,
       .low_memory_critical_limit_mb = low_memory_critical_limit_mb,
-      .sample_ratio_to_be_positive = kFreeMemorySampleRatioToBePositive.Get(),
   };
 }
 

components/exo/wayland/clients/client_base.cc

@@ -926,8 +926,8 @@ std::unique_ptr<ClientBase::Buffer> ClientBase::CreateDrmBuffer(
         .components =
             {
                 .r = VK_COMPONENT_SWIZZLE_IDENTITY,
-                .b = VK_COMPONENT_SWIZZLE_IDENTITY,
                 .g = VK_COMPONENT_SWIZZLE_IDENTITY,
+                .b = VK_COMPONENT_SWIZZLE_IDENTITY,
                 .a = VK_COMPONENT_SWIZZLE_IDENTITY,
             },
         .subresourceRange =

components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc

@@ -675,8 +675,8 @@ struct FillingAssistanceTestCase {
     std::string value;
     std::string typed_value;
     bool user_typed = false;
-    bool manually_filled = false;
     bool automatically_filled = false;
+    bool manually_filled = false;
     bool is_password = false;
   };
 
@@ -885,8 +885,8 @@ TEST(PasswordFormMetricsRecorder, FillingAssistanceUserTypedPassword) {
       {.description_for_logging = "The user typed into password field",
        .fields = {{.value = "user2", .automatically_filled = true},
                   {.typed_value = "password2",
-                   .automatically_filled = true,
                    .user_typed = true,
+                   .automatically_filled = true,
                    .is_password = true}},
        .saved_usernames = {"user1", "user2"},
        .saved_passwords = {"password1", "password2"},
@@ -917,8 +917,8 @@ TEST(PasswordFormMetricsRecorder, FillingAssistanceUserTypedNewCredentials) {
                       .automatically_filled = true,
                   },
                   {.typed_value = "password3",
-                   .automatically_filled = true,
                    .user_typed = true,
+                   .automatically_filled = true,
                    .is_password = true}},
        .saved_usernames = {"user1", "user2"},
        .saved_passwords = {"password1", "password2"},
@@ -988,9 +988,9 @@ TEST(PasswordFormMetricsRecorder,
 TEST(PasswordFormMetricsRecorder, FillingAssistanceBlacklistedDomain) {
   CheckFillingAssistanceTestCase(
       {.description_for_logging = "Submission while domain is blacklisted",
+       .is_blacklisted = true,
        .fields = {{.value = "user1"},
                   {.value = "password1", .is_password = true}},
-       .is_blacklisted = true,
        .saved_usernames = {},
        .saved_passwords = {},
        .expectation = PasswordFormMetricsRecorder::FillingAssistance::
@@ -1002,11 +1002,13 @@ TEST(PasswordFormMetricsRecorder,
   CheckFillingAssistanceTestCase(
       {.description_for_logging =
            "Submission while domain is blacklisted but a credential is stored",
-       .fields = {{.value = "user1", .automatically_filled = true},
-                  {.value = "password1",
-                   .is_password = true,
-                   .automatically_filled = true}},
        .is_blacklisted = true,
+       .fields = {{.value = "user1", .automatically_filled = true},
+                  {
+                      .value = "password1",
+                      .automatically_filled = true,
+                      .is_password = true,
+                  }},
        .saved_usernames = {"user1"},
        .saved_passwords = {"password1"},
        .expectation =

components/password_manager/core/browser/password_manager_unittest.cc

@@ -2926,8 +2926,8 @@ TEST_F(PasswordManagerTest, ReportMissingFormManager) {
       {
           .description =
               "A form is submitted and a PasswordFormManager not present.",
-          .parsed_forms = {},
           .save_signal = MissingFormManagerTestCase::Signal::Automatic,
+          .parsed_forms = {},
           // .parsed_forms is empty, so the processed form below was not
           // observed and has no form manager associated.
           .processed_forms = {form},
@@ -2938,8 +2938,8 @@ TEST_F(PasswordManagerTest, ReportMissingFormManager) {
       {
           .description = "Manual saving is requested and a "
                          "PasswordFormManager is created.",
-          .parsed_forms = {},
           .save_signal = MissingFormManagerTestCase::Signal::Manual,
+          .parsed_forms = {},
           // .parsed_forms is empty, so the processed form below was not
           // observed and has no form manager associated.
           .processed_forms = {form},
@@ -2948,8 +2948,8 @@ TEST_F(PasswordManagerTest, ReportMissingFormManager) {
       },
       {
           .description = "Manual saving is successfully requested.",
-          .parsed_forms = {form},
           .save_signal = MissingFormManagerTestCase::Signal::Manual,
+          .parsed_forms = {form},
           .processed_forms = {form},
           .expected_metric_value = MetricValue(
               PasswordManagerMetricsRecorder::FormManagerAvailable::kSuccess),
@@ -2957,16 +2957,16 @@ TEST_F(PasswordManagerTest, ReportMissingFormManager) {
       {
           .description =
               "A form is submitted and a PasswordFormManager present.",
-          .parsed_forms = {form},
           .save_signal = MissingFormManagerTestCase::Signal::Automatic,
+          .parsed_forms = {form},
           .processed_forms = {form},
           .expected_metric_value = MetricValue(
               PasswordManagerMetricsRecorder::FormManagerAvailable::kSuccess),
       },
       {
           .description = "First failure, then success.",
-          .parsed_forms = {form},
           .save_signal = MissingFormManagerTestCase::Signal::Automatic,
+          .parsed_forms = {form},
           // Processing |other_form| first signals a failure value in the
           // metric, but processing |form| after that should overwrite that with
           // kSuccess.
@@ -2976,16 +2976,16 @@ TEST_F(PasswordManagerTest, ReportMissingFormManager) {
       },
       {
           .description = "No forms, no report.",
-          .parsed_forms = {},
           .save_signal = MissingFormManagerTestCase::Signal::None,
+          .parsed_forms = {},
           .processed_forms = {},
           .expected_metric_value = base::nullopt,
       },
       {
           .description = "Not enabled, no report.",
           .saving = MissingFormManagerTestCase::Saving::Disabled,
-          .parsed_forms = {form},
           .save_signal = MissingFormManagerTestCase::Signal::Automatic,
+          .parsed_forms = {form},
           .processed_forms = {form},
           .expected_metric_value = base::nullopt,
       },