VideoSurfaceLayer: handle context lost between scheduling and submission of frame.

Bug: 855051, 853609
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ieedad00a60f3a64cf256771dc234953a928b5073
Reviewed-on: https://chromium-review.googlesource.com/1110667Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569417}

third_party/blink/renderer/platform/graphics/video_frame_submitter.cc

@@ -200,7 +200,11 @@ void VideoFrameSubmitter::SubmitFrame(
     scoped_refptr<media::VideoFrame> video_frame) {
   TRACE_EVENT0("media", "VideoFrameSubmitter::SubmitFrame");
   DCHECK_CALLED_ON_VALID_THREAD(media_thread_checker_);
-  DCHECK(compositor_frame_sink_);
+
+  // The context may have been destroyed between the call being scheduled and it
+  // running. The lack of compositor_frame_sink_ is used as a sign.
+  if (!compositor_frame_sink_)
+    return;
 
   viz::CompositorFrame compositor_frame;
   std::unique_ptr<viz::RenderPass> render_pass = viz::RenderPass::Create();

third_party/blink/renderer/platform/graphics/video_frame_submitter.h

@@ -82,6 +82,8 @@ class PLATFORM_EXPORT VideoFrameSubmitter
   void DidDeleteSharedBitmap(const viz::SharedBitmapId&) override;
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(VideoFrameSubmitterTest, ContextLostDuringSubmit);
+
   void StartSubmitting();
   void SubmitFrame(viz::BeginFrameAck, scoped_refptr<media::VideoFrame>);
 

third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

@@ -483,4 +483,29 @@ TEST_F(VideoFrameSubmitterTest, WaitingForAckPreventsNewFrame) {
   scoped_task_environment_.RunUntilIdle();
 }
 
+// Test that no crash happens if the context is lost during a frame submission.
+TEST_F(VideoFrameSubmitterTest, ContextLostDuringSubmit) {
+  MakeSubmitter();
+  scoped_task_environment_.RunUntilIdle();
+
+  EXPECT_CALL(*sink_, SetNeedsBeginFrame(true));
+
+  submitter_->StartRendering();
+  scoped_task_environment_.RunUntilIdle();
+
+  EXPECT_CALL(*provider_, GetCurrentFrame())
+      .WillOnce(Return(media::VideoFrame::CreateFrame(
+          media::PIXEL_FORMAT_YV12, gfx::Size(8, 8), gfx::Rect(gfx::Size(8, 8)),
+          gfx::Size(8, 8), base::TimeDelta())));
+  EXPECT_CALL(*provider_, PutCurrentFrame());
+
+  // This will post a task that will later call SubmitFrame(). The call will
+  // happen after OnContextLost().
+  submitter_->SubmitSingleFrame();
+
+  submitter_->OnContextLost();
+
+  scoped_task_environment_.RunUntilIdle();
+}
+
 }  // namespace blink