Commit 28b16872 authored by Gyuyoung Kim's avatar Gyuyoung Kim Committed by Commit Bot

FMPDetector: Remove unused timout constants

kNetwork0QuietWindowTimeout and kNetwork2QuietWindowTimeout constants have not used
anywhere since "FMPDetector: Use network quiet signal from IdlenessDetector" commit.

This CL removes them and all uses in FirstMeaningfulPaintDetector.

Bug: 659021,850403
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I48c3349d208818ceb8d3cde18fdd7177e310b788
Reviewed-on: https://chromium-review.googlesource.com/1237896Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#594154}
parent e5b36c21
......@@ -24,9 +24,6 @@ const int kBlankCharactersThreshold = 200;
} // namespace
constexpr TimeDelta FirstMeaningfulPaintDetector::kNetwork2QuietWindowTimeout;
constexpr TimeDelta FirstMeaningfulPaintDetector::kNetwork0QuietWindowTimeout;
FirstMeaningfulPaintDetector& FirstMeaningfulPaintDetector::From(
Document& document) {
return PaintTiming::From(document).GetFirstMeaningfulPaintDetector();
......
......@@ -57,13 +57,6 @@ class CORE_EXPORT FirstMeaningfulPaintDetector
kDeferFirstContentfulPaintNotSet
};
// The page is n-quiet if there are no more than n active network requests for
// this duration of time.
static constexpr TimeDelta kNetwork2QuietWindowTimeout =
TimeDelta::FromSecondsD(0.5);
static constexpr TimeDelta kNetwork0QuietWindowTimeout =
TimeDelta::FromSecondsD(0.5);
Document* GetDocument();
int ActiveConnections();
void ReportHistograms();
......@@ -80,8 +73,6 @@ class CORE_EXPORT FirstMeaningfulPaintDetector
TimeTicks provisional_first_meaningful_paint_swap_;
double max_significance_so_far_ = 0.0;
double accumulated_significance_while_having_blank_text_ = 0.0;
TimeDelta network2_quiet_window_timeout_ = kNetwork2QuietWindowTimeout;
TimeDelta network0_quiet_window_timeout_ = kNetwork0QuietWindowTimeout;
unsigned prev_layout_object_count_ = 0;
bool seen_first_meaningful_paint_candidate_ = false;
bool network0_quiet_reached_ = false;
......
......@@ -103,13 +103,6 @@ class FirstMeaningfulPaintDetectorTest : public PageTestBase {
protected:
ScopedTestingPlatformSupport<TestingPlatformSupportWithMockScheduler>
platform_;
TimeDelta GetNetwork0QuietWindowTimeout() {
return FirstMeaningfulPaintDetector::kNetwork0QuietWindowTimeout;
}
TimeDelta GetNetwork2QuietWindowTimeout() {
return FirstMeaningfulPaintDetector::kNetwork2QuietWindowTimeout;
}
};
TEST_F(FirstMeaningfulPaintDetectorTest, NoFirstPaint) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment